Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0047367

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

minor

have not tried

2021-07-08 17:10

2021-07-20 08:41

Reporter

collazoandy4

View Status

public

Assigned To

rqueralta

Priority

normal

Resolution

fixed

Fixed in Version

RR21Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

merged

Review Assigned To

adrianromero

OBNetwork customer

Gold

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0047367: Do not check barcode duplicity in digital coupons if barcode is empty

Description

When a draft ticket have a digital coupon payment with an empty barcode and in another ticket we try to add a new digital coupon payment with an empty barcode the duplicity check is throw

Steps To Reproduce

As White Valley Group Admin Role enable Check Barcode duplicity in Digital Coupons preference
Log-in in the POS (YS-11 livebuilds with modules)
Add a product
Go to the payment tab
Add a "Digital Coupon" as payment
Fill the coupon data and an empty barcode
Create a new receipt
Add a product
Go to the payment tab
Add a "Digital Coupon" as payment
Fill the coupon data with an empty barcode
Check the second coupon payment can't be created because the barcode is duplicated

Proposed Solution

Do not check duplicity if the barcode is empty

Tags

No tags attached.

Avoid-duplicated-check-if-barcode-is-empty.patch [^] (922 bytes) 2021-07-08 17:11 [Show Content] [Hide Content]

---
 .../js/hooks/hookObidcoPreAddCouponHook.js                   | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/web/org.openbravo.retail.chequecadeau/js/hooks/hookObidcoPreAddCouponHook.js b/web/org.openbravo.retail.chequecadeau/js/hooks/hookObidcoPreAddCouponHook.js
index 4910589..f31699d 100644
--- a/web/org.openbravo.retail.chequecadeau/js/hooks/hookObidcoPreAddCouponHook.js
+++ b/web/org.openbravo.retail.chequecadeau/js/hooks/hookObidcoPreAddCouponHook.js
@@ -14,7 +14,10 @@
     args,
     callback
   ) {
-    if (OB.MobileApp.model.hasPermission('CCGS_CheckBarcodeDuplicity', true)) {
+    if (
+      OB.MobileApp.model.hasPermission('CCGS_CheckBarcodeDuplicity', true) &&
+      !_.isEmpty(args.coupon.get('ccgsBarcode'))
+    ) {
       var procesValidateDate = new OB.DS.Process(
         'org.openbravo.retail.chequecadeau.hooks.ValidateChequeCadeauBarcode'
       );
-- 
2.28.0

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

closed

Check barcode duplicity in Digital Coupons

Notes
(0130587) hgbot (developer) 2021-07-19 18:44	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/merge_requests/8 [^]

(0130592) hgbot (developer) 2021-07-20 08:38	Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau [^] Changeset: 36495846ba395196cd573bb6e625f219ab34645b Author: Rafael Queralta <rafaelcuba81@gmail.com> Date: 2021-07-18T22:09:38-04:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/commit/36495846ba395196cd573bb6e625f219ab34645b [^] Fixed BUG-47367: Do not check duplicity if the barcode is empty --- M web/org.openbravo.retail.chequecadeau/js/hooks/hookObidcoPreAddCouponHook.js ---

(0130593) hgbot (developer) 2021-07-20 08:38	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/merge_requests/8 [^]

(0130594) adrianromero (viewer) 2021-07-20 08:41	Reviewed and close.

Issue History
Date Modified	Username	Field	Change
2021-07-08 17:10	collazoandy4	New Issue
2021-07-08 17:10	collazoandy4	Assigned To	=> Retail
2021-07-08 17:10	collazoandy4	OBNetwork customer	=> Gold
2021-07-08 17:10	collazoandy4	Resolution time	=> 1626904800
2021-07-08 17:10	collazoandy4	Triggers an Emergency Pack	=> No
2021-07-08 17:11	collazoandy4	File Added: Avoid-duplicated-check-if-barcode-is-empty.patch
2021-07-08 17:12	collazoandy4	Relationship added	related to 0046378
2021-07-09 08:14	marvintm	Resolution time	1626904800 => 1627509600
2021-07-16 14:23	rqueralta	Assigned To	Retail => rqueralta
2021-07-19 18:44	hgbot	Merge Request Status	=> open
2021-07-19 18:44	hgbot	Note Added: 0130587
2021-07-19 22:54	rqueralta	Status	new => scheduled
2021-07-20 08:38	hgbot	Resolution	open => fixed
2021-07-20 08:38	hgbot	Status	scheduled => resolved
2021-07-20 08:38	hgbot	Note Added: 0130592
2021-07-20 08:38	hgbot	Merge Request Status	open => merged
2021-07-20 08:38	hgbot	Note Added: 0130593
2021-07-20 08:41	adrianromero	Review Assigned To	=> adrianromero
2021-07-20 08:41	adrianromero	Note Added: 0130594
2021-07-20 08:41	adrianromero	Status	resolved => closed
2021-07-20 08:41	adrianromero	Fixed in Version	=> RR21Q3

Copyright © 2000 - 2009 MantisBT Group