Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0047007 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [POS2] POS | major | have not tried | 2021-06-01 08:20 | 2021-06-24 11:13 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | prakashmurugesan88 | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | TAP | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0047007: Errors sending email must be caught | |||||||
| Description | If there is an error during the processing of OBPOS2_SendEmail error (for example because the template generation failed), the message generated to make this processing is never deleted by the synchronization buffer as it will try to reprocess it forever. Thus, the subsequent messages to be synchronized in the backend will not be processed and they will be kept in the queue. Besides all this issue happens silently, nothing is displayed in the UI to inform that there is a problem | |||||||
| Steps To Reproduce | 0) Apply the attached patch in pos2 module which simulates an error processing the send email message 1) Configure pos to use the send email feature[1] 2) Send an email (it will fail due to the applied patch). Note that starting from this moment all the messages to be synchronized in the backend are kept in the queue and never processed...see attached image [1] https://docs.google.com/document/d/1QhygcFWnc2rwRUe8EaC02e5c91xXeEA3w6XUplhTn5Q/edit#heading=h.mpsw99anuiy6 [^] | |||||||
| Proposed Solution | Do not allow sendEmail[1] to throw errors: - In case of error it should be catched. This way the message will be processed by the synchronization buffer without errors and eventually deleted from the queue. - In addition to catching the error, it should be managed and a message should be displayed to the user in order to inform about the problem [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/services/emailHandler.js#L34 [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0129750) prakashmurugesan88 (developer) 2021-06-23 17:39 |
Created Merge Request, https://gitlab.com/obcustomers/AGAP/org.openbravo.pos2/-/merge_requests/67 [^] |
|
(0129765) prakashmurugesan88 (developer) 2021-06-24 11:12 |
Fixed in following commit, https://gitlab.com/obcustomers/AGAP/org.openbravo.pos2/-/commit/0d3a3ad3dfd90a88dde224ab34cc2f92c19314d6 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-06-07 15:06 | guilleaer | Type | defect => backport |
| 2021-06-07 15:06 | guilleaer | Target Version | => TAP |
| 2021-06-07 15:06 | guilleaer | Status | scheduled => acknowledged |
| 2021-06-21 15:02 | prakashmurugesan88 | Assigned To | Retail => prakashmurugesan88 |
| 2021-06-21 15:02 | prakashmurugesan88 | Status | acknowledged => scheduled |
| 2021-06-23 17:39 | prakashmurugesan88 | Note Added: 0129750 | |
| 2021-06-24 11:12 | prakashmurugesan88 | Note Added: 0129765 | |
| 2021-06-24 11:12 | prakashmurugesan88 | Status | scheduled => resolved |
| 2021-06-24 11:12 | prakashmurugesan88 | Resolution | open => fixed |
| 2021-06-24 11:13 | prakashmurugesan88 | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |