0047007: Errors sending email must be caught - Openbravo Issue Tracking System

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0047007

POS2

POS

public

2021-06-01 08:20

2021-06-24 11:13

Reporter

caristu

Assigned To

prakashmurugesan88

Priority

high

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

TAP

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0047007: Errors sending email must be caught

Description

If there is an error during the processing of OBPOS2_SendEmail error (for example because the template generation failed), the message generated to make this processing is never deleted by the synchronization buffer as it will try to reprocess it forever. Thus, the subsequent messages to be synchronized in the backend will not be processed and they will be kept in the queue.

Besides all this issue happens silently, nothing is displayed in the UI to inform that there is a problem

Steps To Reproduce

0) Apply the attached patch in pos2 module which simulates an error processing the send email message
1) Configure pos to use the send email feature[1]
2) Send an email (it will fail due to the applied patch). Note that starting from this moment all the messages to be synchronized in the backend are kept in the queue and never processed...see attached image

[1] https://docs.google.com/document/d/1QhygcFWnc2rwRUe8EaC02e5c91xXeEA3w6XUplhTn5Q/edit#heading=h.mpsw99anuiy6 [^]

Proposed Solution

Do not allow sendEmail[1] to throw errors:

- In case of error it should be catched. This way the message will be processed by the synchronization buffer without errors and eventually deleted from the queue.

- In addition to catching the error, it should be managed and a message should be displayed to the user in order to inform about the problem

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/services/emailHandler.js#L34 [^]

Additional Information