Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0045494 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Coupons OTF | major | always | 2020-11-24 11:13 | 2021-06-09 11:37 | |||
Reporter | wicherr | View Status | public | |||||
Assigned To | ranjith_qualiantech_com | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0045494: OTF rules expired continue to generate coupons | |||||||
Description | When an OTF rule is expired, even after till refresh (not full refresh), the rule continues to generate coupons. For information, the "refresh data" updated the ending date well in the web browser cache. | |||||||
Steps To Reproduce | - Create a valid OTF rule - Check on webPOS the rule generate a coupon - Change the ending date to a previous date than today - Refresh the terminal (menu > Refresh data) - do the same ticket than previously => The coupon is still generated To reproduce, I used the last version in livebuild with modules. We need a fix on 20q3 for Norauto. | |||||||
Proposed Solution | If the OTF rule is expired, the coupons should stop to be generated. A patch has been attached | |||||||
Tags | NOR, NORAUTO | |||||||
Attached Files | OTF.patch [^] (1,247 bytes) 2021-02-09 11:00 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |||||||||||||||
|
Notes | |
(0126023) rafaroda (developer) 2021-02-08 10:10 edited on: 2021-02-08 10:11 |
Patch will be added by Christophe Brazier |
(0126114) hgbot (developer) 2021-02-16 06:47 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/10 [^] |
(0126190) hgbot (developer) 2021-02-19 08:11 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^] Changeset: 12e7571e2850182936edd9d3d8688e78a94ab798 Author: Ranjith S R <ranjith@qualiantech.com> Date: 2021-02-15T17:00:58+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/12e7571e2850182936edd9d3d8688e78a94ab798 [^] Fixed ISSUE-45494: Filter Coupon Rule by Current Date * Filter Coupon Rule by Current Date by comparing with starting date and ending date --- M web/org.openbravo.retail.discounts.coupons.otf/js/utils.js --- |
(0126191) hgbot (developer) 2021-02-19 08:11 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/10 [^] |
(0129248) sebastien_liron (reporter) 2021-06-09 11:37 |
It might lake this line, since new Date () will take the current hour, etc ... now.setHours(0, 0, 0, 0); |
Issue History | |||
Date Modified | Username | Field | Change |
2020-11-24 11:13 | wicherr | New Issue | |
2020-11-24 11:13 | wicherr | Assigned To | => Retail |
2020-11-24 11:13 | wicherr | Triggers an Emergency Pack | => No |
2020-11-24 11:13 | wicherr | Tag Attached: NOR | |
2020-11-24 11:13 | wicherr | Tag Attached: NORAUTO | |
2020-11-27 12:25 | AugustoMauch | File Added: issue45494.diff | |
2020-11-27 12:26 | AugustoMauch | Proposed Solution updated | |
2020-11-27 13:15 | rafaroda | Relationship added | related to 0045495 |
2020-11-27 21:59 | rafaroda | File Deleted: issue45494.diff | |
2021-02-08 10:10 | rafaroda | Resolution time | => 1614726000 |
2021-02-08 10:10 | rafaroda | Note Added: 0126023 | |
2021-02-08 10:11 | rafaroda | Note Edited: 0126023 | View Revisions |
2021-02-08 10:11 | rafaroda | Issue Monitored: rafaroda | |
2021-02-09 10:59 | cbrazier | Issue Monitored: cbrazier | |
2021-02-09 10:59 | cbrazier | Issue End Monitor: cbrazier | |
2021-02-09 11:00 | cbrazier | File Added: OTF.patch | |
2021-02-11 15:31 | rafaroda | Relationship added | related to 0045885 |
2021-02-15 05:39 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
2021-02-15 11:44 | ranjith_qualiantech_com | Status | new => scheduled |
2021-02-16 06:47 | hgbot | Note Added: 0126114 | |
2021-02-19 08:11 | hgbot | Resolution | open => fixed |
2021-02-19 08:11 | hgbot | Status | scheduled => closed |
2021-02-19 08:11 | hgbot | Note Added: 0126190 | |
2021-02-19 08:11 | hgbot | Note Added: 0126191 | |
2021-06-09 11:37 | sebastien_liron | Note Added: 0129248 |
Copyright © 2000 - 2009 MantisBT Group |