Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0045315
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] [Retail Modules] Web POSminorhave not tried2020-10-28 10:082021-02-22 11:47
ReportermigueldejuanaView Statuspublic 
Assigned Tojarmendariz 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045315: Linter pre-commit hook is not watching for jsx files

DescriptionLinter pre-commit hook is not watching for jsx files.

If we have a ESLint error in a .jsx file, the pre-commit hook is just watching for js files and it allows us to push the ESLint error.
Steps To ReproduceModify in a jsx file '===' to '=='. Check that vsCode tell us that is an ESLint error but when commiting the change, the hook is not stopping the process.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0045326 closedjarmendariz POS2 Linting in BL files is not working 
related to feature request 0045516 closedjarmendariz Openbravo ERP Upgrade ESLint and Jest to its latest version 

-  Notes
(0124615)
guilleaer (viewer)
2020-11-25 12:13

 This issue will be resolved as part of the task
nwp2_JslintMergeReact
(0125801)
guilleaer (viewer)
2021-01-27 12:37

 MR associated

https://gitlab.com/openbravo/devel/openbravo/-/merge_requests/3 [^]
(0125849)
AugustoMauch (administrator)
2021-01-29 09:49

 Code reviewed and verified
(0126174)
hgbot (developer)
2021-02-19 06:44

 Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: f21edcb62ad5197c766b29911369308a8aec30c9
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-02-19T05:39:28+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/f21edcb62ad5197c766b29911369308a8aec30c9 [^]

[react] fixed ISSUE-45315: Linter and Formatter git hooks checks both .js and .jsx files

---
M .githooks/pre-commit.d/00-jslint
M .githooks/pre-commit.d/01-jsformatter
---

- Issue History
Date Modified Username Field Change
2020-10-28 10:08 migueldejuana New Issue
2020-10-28 10:08 migueldejuana Assigned To => platform
2020-10-28 10:08 migueldejuana OBNetwork customer => No
2020-10-28 10:08 migueldejuana Triggers an Emergency Pack => No
2020-10-28 11:11 jarmendariz Assigned To platform => jarmendariz
2020-10-28 11:11 jarmendariz Assigned To jarmendariz => platform
2020-10-28 11:19 jarmendariz Project Retail Modules => POS2
2020-11-25 12:12 guilleaer Relationship added related to 0045326
2020-11-25 12:12 guilleaer Status new => scheduled
2020-11-25 12:12 guilleaer Assigned To platform => jarmendariz
2020-11-25 12:13 guilleaer Note Added: 0124615
2020-11-26 14:01 jarmendariz Relationship added related to 0045516
2021-01-27 12:37 guilleaer Note Added: 0125801
2021-01-29 08:57 jarmendariz Status scheduled => resolved
2021-01-29 08:57 jarmendariz Resolution open => fixed
2021-01-29 09:49 AugustoMauch Review Assigned To => AugustoMauch
2021-01-29 09:49 AugustoMauch Note Added: 0125849
2021-01-29 09:49 AugustoMauch Status resolved => closed
2021-02-19 06:44 hgbot Status closed => resolved
2021-02-19 06:44 hgbot Fixed in Version => PR21Q2
2021-02-19 06:44 hgbot Note Added: 0126174
2021-02-22 11:47 AugustoMauch Status resolved => closed
2021-02-22 11:47 AugustoMauch Fixed in Version PR21Q2 =>

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker