Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045315POS2[Retail Modules] Web POSpublic2020-10-28 10:082021-02-22 11:47
Reportermigueldejuana 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045315: Linter pre-commit hook is not watching for jsx files
DescriptionLinter pre-commit hook is not watching for jsx files.

If we have a ESLint error in a .jsx file, the pre-commit hook is just watching for js files and it allows us to push the ESLint error.
Steps To ReproduceModify in a jsx file '===' to '=='. Check that vsCode tell us that is an ESLint error but when commiting the change, the hook is not stopping the process.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0045326 closed jarmendariz POS2 Linting in BL files is not working 
related to feature request 0045516 closed jarmendariz Openbravo ERP Upgrade ESLint and Jest to its latest version 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-10-28 10:08migueldejuanaNew Issue
2020-10-28 10:08migueldejuanaAssigned To => platform
2020-10-28 10:08migueldejuanaTriggers an Emergency Pack => No
2020-10-28 11:11jarmendarizAssigned Toplatform => jarmendariz
2020-10-28 11:11jarmendarizAssigned Tojarmendariz => platform
2020-10-28 11:19jarmendarizProjectRetail Modules => POS2
2020-11-25 12:12guilleaerRelationship addedrelated to 0045326
2020-11-25 12:12guilleaerStatusnew => scheduled
2020-11-25 12:12guilleaerAssigned Toplatform => jarmendariz
2020-11-25 12:13guilleaerNote Added: 0124615
2020-11-26 14:01jarmendarizRelationship addedrelated to 0045516
2021-01-27 12:37guilleaerNote Added: 0125801
2021-01-29 08:57jarmendarizStatusscheduled => resolved
2021-01-29 08:57jarmendarizResolutionopen => fixed
2021-01-29 09:49AugustoMauchReview Assigned To => AugustoMauch
2021-01-29 09:49AugustoMauchNote Added: 0125849
2021-01-29 09:49AugustoMauchStatusresolved => closed
2021-02-19 06:44hgbotStatusclosed => resolved
2021-02-19 06:44hgbotFixed in Version => PR21Q2
2021-02-19 06:44hgbotNote Added: 0126174
2021-02-22 11:47AugustoMauchStatusresolved => closed
2021-02-22 11:47AugustoMauchFixed in VersionPR21Q2 =>

Notes
(0124615)
guilleaer   
2020-11-25 12:13   
This issue will be resolved as part of the task
nwp2_JslintMergeReact
(0125801)
guilleaer   
2021-01-27 12:37   
MR associated

https://gitlab.com/openbravo/devel/openbravo/-/merge_requests/3 [^]
(0125849)
AugustoMauch   
2021-01-29 09:49   
Code reviewed and verified
(0126174)
hgbot   
2021-02-19 06:44   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: f21edcb62ad5197c766b29911369308a8aec30c9
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-02-19T05:39:28+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/f21edcb62ad5197c766b29911369308a8aec30c9 [^]

[react] fixed ISSUE-45315: Linter and Formatter git hooks checks both .js and .jsx files

---
M .githooks/pre-commit.d/00-jslint
M .githooks/pre-commit.d/01-jsformatter
---