Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0044773
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorrandom2020-08-10 13:242022-04-11 15:01
ReporterguillermogilView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityurgentResolutionfixedFixed in VersionRR20Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0044773: Delete Ticket does not wait for the CalculateReceipt execution

DescriptionDelete Ticket does not wait for the CalculateReceipt execution.
It just executes the calculate receipt and it may rely on wrong data generation such as no tax.
As orderloader does not fail the Sales Order has some missing data.
Steps To ReproduceAs it is random we cannot ensure the steps
It just happens on standard ticket deletion
Proposed SolutionThe main problem here is that in some cases, the ticket may be modified while it is being synchronised to the backend (in case the Save Removed Tickets preference is activated). This is a problem because it may cause inconsistencies in the ticket that is finally sent to the backend.

The best way to prevent the problem is to implement the same change we did for the main ticket completion mechanism. In the "markOrdersAsDeleted" function, we should clone the main receipt, and all logic related to synchronisation, like the execution of the PresyncReceipt hook and everything else, should happen against this cloned instance.

This way we will ensure that if there is any uncontrolled process trying to mutate the ticket, at least it will not influence the synchronisation process itself and the consistency of the data.
TagsNOR
Attached Filesdiff file icon 44773_posterminal_19Q3.diff [^] (5,414 bytes) 2021-01-19 09:59 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0043481 closedranjith_qualiantech_com Order Error Deleting Lines With SUPR key 
related to defect 0055002 closedRajesh_18 Error when trying to change line quantity after deleting an order 

-  Notes
(0122084)
hgbot (developer)
2020-08-17 07:15

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/60 [^]
(0122109)
hgbot (developer)
2020-08-18 07:34

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/60 [^]
(0122110)
hgbot (developer)
2020-08-18 07:35

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 1e218a7c4e216328072e77f9976cba89857f463c
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-08-18T05:34:50+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1e218a7c4e216328072e77f9976cba89857f463c [^]

Fixed ISSUE-44773: Updated Delete Ticket Sync Process
* With Pref. Save Removed Ticket is enabled, cloned receipt should be used for Sync process to avoid any modification when syncing the receipt

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0135780)
hgbot (developer)
2022-03-16 15:03

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/748 [^]
(0136466)
hgbot (developer)
2022-04-11 15:01

Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/748 [^]

- Issue History
Date Modified Username Field Change
2020-08-10 13:24 guillermogil New Issue
2020-08-10 13:24 guillermogil Assigned To => Retail
2020-08-10 13:24 guillermogil Resolution time => 1598824800
2020-08-10 13:24 guillermogil Triggers an Emergency Pack => No
2020-08-10 14:45 marvintm Proposed Solution updated
2020-08-11 12:09 martinsdan Issue Monitored: martinsdan
2020-08-13 15:21 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2020-08-13 15:25 ranjith_qualiantech_com Status new => scheduled
2020-08-17 07:15 hgbot Note Added: 0122084
2020-08-18 07:34 hgbot Note Added: 0122109
2020-08-18 07:35 hgbot Resolution open => fixed
2020-08-18 07:35 hgbot Status scheduled => closed
2020-08-18 07:35 hgbot Fixed in Version => RR20Q4
2020-08-18 07:35 hgbot Note Added: 0122110
2020-09-23 15:46 ngarcia Relationship added related to 0043481
2020-09-23 21:30 rafaroda Tag Attached: NOR
2021-01-19 09:59 ranjith_qualiantech_com File Added: 44773_posterminal_19Q3.diff
2022-03-16 15:03 hgbot Note Added: 0135780
2022-04-11 15:01 hgbot Note Added: 0136466
2024-03-20 00:45 ivazquez Relationship added related to 0055002


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker