Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0044773 | Retail Modules | Web POS | public | 2020-08-10 13:24 | 2022-04-11 15:01 |
|
| Reporter | guillermogil | |
| Assigned To | ranjith_qualiantech_com | |
| Priority | urgent | Severity | major | Reproducibility | random |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR20Q4 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0044773: Delete Ticket does not wait for the CalculateReceipt execution |
| Description | Delete Ticket does not wait for the CalculateReceipt execution.
It just executes the calculate receipt and it may rely on wrong data generation such as no tax.
As orderloader does not fail the Sales Order has some missing data. |
| Steps To Reproduce | As it is random we cannot ensure the steps
It just happens on standard ticket deletion |
| Proposed Solution | The main problem here is that in some cases, the ticket may be modified while it is being synchronised to the backend (in case the Save Removed Tickets preference is activated). This is a problem because it may cause inconsistencies in the ticket that is finally sent to the backend.
The best way to prevent the problem is to implement the same change we did for the main ticket completion mechanism. In the "markOrdersAsDeleted" function, we should clone the main receipt, and all logic related to synchronisation, like the execution of the PresyncReceipt hook and everything else, should happen against this cloned instance.
This way we will ensure that if there is any uncontrolled process trying to mutate the ticket, at least it will not influence the synchronisation process itself and the consistency of the data. |
| Additional Information | |
| Tags | NOR |
| Relationships | | related to | defect | 0043481 | | closed | ranjith_qualiantech_com | Order Error Deleting Lines With SUPR key | | related to | defect | 0055002 | | closed | Rajesh_18 | Error when trying to change line quantity after deleting an order |
|
| Attached Files |  44773_posterminal_19Q3.diff (5,414) 2021-01-19 09:59
https://issues.openbravo.com/file_download.php?file_id=15264&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2020-08-10 13:24 | guillermogil | New Issue | |
| 2020-08-10 13:24 | guillermogil | Assigned To | => Retail |
| 2020-08-10 13:24 | guillermogil | Resolution time | => 1598824800 |
| 2020-08-10 13:24 | guillermogil | Triggers an Emergency Pack | => No |
| 2020-08-10 14:45 | marvintm | Proposed Solution updated | |
| 2020-08-11 12:09 | martinsdan | Issue Monitored: martinsdan | |
| 2020-08-13 15:21 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2020-08-13 15:25 | ranjith_qualiantech_com | Status | new => scheduled |
| 2020-08-17 07:15 | hgbot | Note Added: 0122084 | |
| 2020-08-18 07:34 | hgbot | Note Added: 0122109 | |
| 2020-08-18 07:35 | hgbot | Resolution | open => fixed |
| 2020-08-18 07:35 | hgbot | Status | scheduled => closed |
| 2020-08-18 07:35 | hgbot | Fixed in Version | => RR20Q4 |
| 2020-08-18 07:35 | hgbot | Note Added: 0122110 | |
| 2020-09-23 15:46 | ngarcia | Relationship added | related to 0043481 |
| 2020-09-23 21:30 | rafaroda | Tag Attached: NOR | |
| 2021-01-19 09:59 | ranjith_qualiantech_com | File Added: 44773_posterminal_19Q3.diff | |
| 2022-03-16 15:03 | hgbot | Note Added: 0135780 | |
| 2022-04-11 15:01 | hgbot | Note Added: 0136466 | |
| 2024-03-20 00:45 | ivazquez | Relationship added | related to 0055002 |