Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044339
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2020-06-10 18:172020-06-15 08:30
ReporteraferrazView Statuspublic 
Assigned Toaferraz 
PrioritynormalResolutionfixedFixed in VersionRR20Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0044339: Use same API in Discount and Tax engine output - Discount engine changes

DescriptionUse same Ticket API in Discount and Tax engine output
Steps To Reproduce*
Proposed SolutionCurrent Discount engine output is as follows:
{
  "lines": {
    "BBC8BD559F1F6830AF7998A180F8D9DA": {
      "discounts": {
        "grossUnitAmount": 261.81,
        "grossUnitPrice": 261.81,
        "promotions": [
          {
            "ruleId": "C26B841C84B14FE2AB1A334DD3672E87",
            "discountType": "697A7AB9FD9C4EE0A3E891D3D3CCA0A7",
            "name": "GPS_10_per",
            "applyNext": true,
            "amt": 29.09,
            "qtyOffer": 1
          }
        ]
      }
    }
  }
}

Change it so it is similar to Tax engine output and Ticket API:
{
  "lines": [
    {
      "id": "0A19E6B3EC1422CDD0139E5BD0AB2FC1",
      "grossUnitAmount": 261.81,
      "grossUnitPrice": 261.81,
      "discounts": [
        {
          "ruleId": "C26B841C84B14FE2AB1A334DD3672E87",
          "discountType": "697A7AB9FD9C4EE0A3E891D3D3CCA0A7",
          "name": "GPS_10_per",
          "applyNext": true,
          "amt": 29.09,
          "qtyOffer": 1
        }
      ]
    }
  ]
}

Add also discountengine namespace when running the engine from graal/node/webservice:
{
  "ticket": {
    "discountengine": {
      "lines": [
        {
          "id": "0A19E6B3EC1422CDD0139E5BD0AB2FC1",
          "grossUnitAmount": 261.81,
          "grossUnitPrice": 261.81,
          "discounts": [...]
        }
      ]
    }
  }
}
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0044181RR20Q3 closedaferraz Use same Ticket API in Discount and Tax engine - Discount engine changes 
related to defect 0044340 closedaferraz Use same API in Discount and Tax engine output - Tax engine changes 

-  Notes
(0120808)
hgbot (developer)
2020-06-12 08:42

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e434f603e2c651dd45780d94053f4d4518f63646
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Jun 10 18:25:58 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e434f603e2c651dd45780d94053f4d4518f63646 [^]

Related to ISSUE-44339: Change discount engine result structure

---
M web/org.openbravo.retail.posterminal/js/discountsengine/pos/pos-discounts.js
---
(0120811)
hgbot (developer)
2020-06-12 08:52

 Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: f19b0652d434bc1ab799c4c1e26751d7afdc9583
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Jun 10 18:26:07 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/f19b0652d434bc1ab799c4c1e26751d7afdc9583 [^]

Related to ISSUE-44339: Change discount engine result structure

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-engine.js
---
(0120812)
hgbot (developer)
2020-06-12 08:53

 Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: a9ef88a1789bfab80b7cd52bb9b69294476e7b65
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Jun 12 08:52:36 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/a9ef88a1789bfab80b7cd52bb9b69294476e7b65 [^]

Related to ISSUE-44339: Change discount engine result structure

---
M src-test/org/openbravo/retail/discounts/test/base/DiscountResult.java
---
(0120817)
hgbot (developer)
2020-06-12 09:08

 Repository: erp/pmods/org.openbravo.discounts
Changeset: b15ae4fcc1e2cc5c71ed32beac5bbe1f6de7abf1
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Jun 12 08:55:38 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.discounts/rev/b15ae4fcc1e2cc5c71ed32beac5bbe1f6de7abf1 [^]

Related to ISSUE-44339: Add discountengine namespace

---
M src-test/org/openbravo/discounts/test/base/executor/DiscountsCalculator.java
M src-test/org/openbravo/discounts/test/base/executor/NodeDiscountsExecutor.java
M src-test/org/openbravo/discounts/test/base/executor/WebServiceDiscountsExecutor.java
M src/org/openbravo/discounts/engine/graal/GraalDiscountsExecutor.java
---
(0120819)
hgbot (developer)
2020-06-12 09:45

 Repository: erp/pmods/org.openbravo.discounts
Changeset: fa7b7ac8625a809aef89c72734e62f1a638919f7
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Jun 12 09:45:47 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.discounts/rev/fa7b7ac8625a809aef89c72734e62f1a638919f7 [^]

Related to ISSUE-44339: Update swagger

---
M api/org.openbravo.discounts-discounts.yml
---

- Issue History
Date Modified Username Field Change
2020-06-10 18:17 aferraz New Issue
2020-06-10 18:17 aferraz Assigned To => aferraz
2020-06-10 18:17 aferraz OBNetwork customer => No
2020-06-10 18:17 aferraz Triggers an Emergency Pack => No
2020-06-10 18:17 aferraz Issue generated from 0044181
2020-06-10 18:17 aferraz Relationship added related to 0044181
2020-06-10 18:21 aferraz Issue cloned 0044340
2020-06-10 18:22 aferraz Relationship added related to 0044340
2020-06-12 08:42 hgbot Checkin
2020-06-12 08:42 hgbot Note Added: 0120808
2020-06-12 08:49 aferraz Proposed Solution updated
2020-06-12 08:52 hgbot Checkin
2020-06-12 08:52 hgbot Note Added: 0120811
2020-06-12 08:53 hgbot Checkin
2020-06-12 08:53 hgbot Note Added: 0120812
2020-06-12 09:08 hgbot Checkin
2020-06-12 09:08 hgbot Note Added: 0120817
2020-06-12 09:29 aferraz Proposed Solution updated
2020-06-12 09:45 hgbot Checkin
2020-06-12 09:45 hgbot Note Added: 0120819
2020-06-12 09:52 aferraz Status new => scheduled
2020-06-12 09:52 aferraz Status scheduled => resolved
2020-06-12 09:52 aferraz Fixed in Version => RR20Q3
2020-06-12 09:52 aferraz Resolution open => fixed
2020-06-15 08:30 marvintm Review Assigned To => marvintm
2020-06-15 08:30 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker