Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044003
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-08 12:232020-05-19 15:33
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision433bc3d54ba7
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0044003: Apply new HQL Style in TGC_StorageDetail_PA.java

DescriptionTGC_StorageDetail_PA.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0119701)
inigo_lerga (reporter)
2020-05-08 14:21

 --Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

As the AWO-QA Admin - AWO-QA role:
  - Go to the Purchase Order window and create a new record
    with any Business Partner desired.
    Go to Lines Tab and create a new Line with any product and
    quantity desired.
    Book the Purchase Order and copy the Search Key.

As the AWO_US_W role in AWO Front End:
  - Open the Put Away window and paste the Search Key. Press search button.

  #In this moment the modified HQL is executed#
(0120044)
hgbot (developer)
2020-05-19 15:32

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 433bc3d54ba7cb58dd3fe0cad0e3cc0f3269ed49
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 08 14:26:34 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/433bc3d54ba7cb58dd3fe0cad0e3cc0f3269ed49 [^]

fixes BUG-44003:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/taskgenerationcandidates/TGC_StorageDetail_PA.java
---
(0120045)
hgbot (developer)
2020-05-19 15:32

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 7503009e16720fdb58fd42597ef0973b063f997f
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue May 19 15:32:29 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/7503009e16720fdb58fd42597ef0973b063f997f [^]

Related to ISSUE 44003. Refactor of class
* Logic to create additional where clause extracted to different method
* Added final modifiers

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/taskgenerationcandidates/TGC_StorageDetail_PA.java
---
(0120047)
dmiguelez (developer)
2020-05-19 15:33

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-08 12:23 inigo_lerga New Issue
2020-05-08 12:23 inigo_lerga Assigned To => inigo_lerga
2020-05-08 12:24 inigo_lerga Relationship added related to 0041287
2020-05-08 12:24 inigo_lerga Status new => scheduled
2020-05-08 14:21 inigo_lerga Note Added: 0119701
2020-05-19 15:32 hgbot Checkin
2020-05-19 15:32 hgbot Note Added: 0120044
2020-05-19 15:32 hgbot Status scheduled => resolved
2020-05-19 15:32 hgbot Resolution open => fixed
2020-05-19 15:32 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/433bc3d54ba7cb58dd3fe0cad0e3cc0f3269ed49 [^]
2020-05-19 15:32 hgbot Checkin
2020-05-19 15:32 hgbot Note Added: 0120045
2020-05-19 15:33 dmiguelez Review Assigned To => dmiguelez
2020-05-19 15:33 dmiguelez Note Added: 0120047
2020-05-19 15:33 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker