Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044003ModulesAdvanced Warehouse Operationspublic2020-05-08 12:232020-05-19 15:33
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044003: Apply new HQL Style in TGC_StorageDetail_PA.java
DescriptionTGC_StorageDetail_PA.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-08 12:23inigo_lergaNew Issue
2020-05-08 12:23inigo_lergaAssigned To => inigo_lerga
2020-05-08 12:24inigo_lergaRelationship addedrelated to 0041287
2020-05-08 12:24inigo_lergaStatusnew => scheduled
2020-05-08 14:21inigo_lergaNote Added: 0119701
2020-05-19 15:32hgbotCheckin
2020-05-19 15:32hgbotNote Added: 0120044
2020-05-19 15:32hgbotStatusscheduled => resolved
2020-05-19 15:32hgbotResolutionopen => fixed
2020-05-19 15:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/433bc3d54ba7cb58dd3fe0cad0e3cc0f3269ed49 [^]
2020-05-19 15:32hgbotCheckin
2020-05-19 15:32hgbotNote Added: 0120045
2020-05-19 15:33dmiguelezReview Assigned To => dmiguelez
2020-05-19 15:33dmiguelezNote Added: 0120047
2020-05-19 15:33dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119701)
inigo_lerga   
2020-05-08 14:21   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

As the AWO-QA Admin - AWO-QA role:
  - Go to the Purchase Order window and create a new record
    with any Business Partner desired.
    Go to Lines Tab and create a new Line with any product and
    quantity desired.
    Book the Purchase Order and copy the Search Key.

As the AWO_US_W role in AWO Front End:
  - Open the Put Away window and paste the Search Key. Press search button.

  #In this moment the modified HQL is executed#
(0120044)
hgbot   
2020-05-19 15:32   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 433bc3d54ba7cb58dd3fe0cad0e3cc0f3269ed49
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 08 14:26:34 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/433bc3d54ba7cb58dd3fe0cad0e3cc0f3269ed49 [^]

fixes BUG-44003:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/taskgenerationcandidates/TGC_StorageDetail_PA.java
---
(0120045)
hgbot   
2020-05-19 15:32   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 7503009e16720fdb58fd42597ef0973b063f997f
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue May 19 15:32:29 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/7503009e16720fdb58fd42597ef0973b063f997f [^]

Related to ISSUE 44003. Refactor of class
* Logic to create additional where clause extracted to different method
* Added final modifiers

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/taskgenerationcandidates/TGC_StorageDetail_PA.java
---
(0120047)
dmiguelez   
2020-05-19 15:33   
Code Review + Testing Ok