Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043976
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-07 10:192020-05-18 17:45
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision4c466c18fc2c
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0043976: Apply new HQL Style in ReferencedInventoryProvider.java

DescriptionReferencedInventoryProvider.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0119660)
inigo_lerga (reporter)
2020-05-07 14:33
edited on: 2020-05-07 14:36

 --Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
As the AWO-QA Admin - AWO-QA role:
  - Go to the Referenced Inventory window and select any available record.
    Copy the Search Key.
As the AWO_US_W role in AWO Front End:
  - Open the Box window and paste the Search Key. Press GO! button.

  #In this moment the modified HQL is executed#
(0120000)
hgbot (developer)
2020-05-18 17:44

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 4c466c18fc2c4ad3ecdda5791457fa99241b2ca5
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 07 14:29:20 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/4c466c18fc2c4ad3ecdda5791457fa99241b2ca5 [^]

fixes BUG-43976:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/ReferencedInventoryProvider.java
---
(0120001)
dmiguelez (developer)
2020-05-18 17:45

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-07 10:19 inigo_lerga New Issue
2020-05-07 10:19 inigo_lerga Assigned To => inigo_lerga
2020-05-07 10:19 inigo_lerga Status new => scheduled
2020-05-07 10:19 inigo_lerga Relationship added related to 0041287
2020-05-07 10:20 inigo_lerga Summary Apply new HQL Style in JsonDataServiceExtraActionsTaskDeletion.java => Apply new HQL Style in ReferencedInventoryProvider.java
2020-05-07 10:20 inigo_lerga Description Updated View Revisions
2020-05-07 14:33 inigo_lerga Note Added: 0119660
2020-05-07 14:36 inigo_lerga Note Edited: 0119660 View Revisions
2020-05-18 17:44 hgbot Checkin
2020-05-18 17:44 hgbot Note Added: 0120000
2020-05-18 17:44 hgbot Status scheduled => resolved
2020-05-18 17:44 hgbot Resolution open => fixed
2020-05-18 17:44 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/4c466c18fc2c4ad3ecdda5791457fa99241b2ca5 [^]
2020-05-18 17:45 dmiguelez Review Assigned To => dmiguelez
2020-05-18 17:45 dmiguelez Note Added: 0120001
2020-05-18 17:45 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker