Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043976ModulesAdvanced Warehouse Operationspublic2020-05-07 10:192020-05-18 17:45
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0043976: Apply new HQL Style in ReferencedInventoryProvider.java
DescriptionReferencedInventoryProvider.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-07 10:19inigo_lergaNew Issue
2020-05-07 10:19inigo_lergaAssigned To => inigo_lerga
2020-05-07 10:19inigo_lergaStatusnew => scheduled
2020-05-07 10:19inigo_lergaRelationship addedrelated to 0041287
2020-05-07 10:20inigo_lergaSummaryApply new HQL Style in JsonDataServiceExtraActionsTaskDeletion.java => Apply new HQL Style in ReferencedInventoryProvider.java
2020-05-07 10:20inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20961#r20961
2020-05-07 14:33inigo_lergaNote Added: 0119660
2020-05-07 14:36inigo_lergaNote Edited: 0119660bug_revision_view_page.php?bugnote_id=0119660#r20967
2020-05-18 17:44hgbotCheckin
2020-05-18 17:44hgbotNote Added: 0120000
2020-05-18 17:44hgbotStatusscheduled => resolved
2020-05-18 17:44hgbotResolutionopen => fixed
2020-05-18 17:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/4c466c18fc2c4ad3ecdda5791457fa99241b2ca5 [^]
2020-05-18 17:45dmiguelezReview Assigned To => dmiguelez
2020-05-18 17:45dmiguelezNote Added: 0120001
2020-05-18 17:45dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119660)
inigo_lerga   
2020-05-07 14:33   
(edited on: 2020-05-07 14:36)
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
As the AWO-QA Admin - AWO-QA role:
  - Go to the Referenced Inventory window and select any available record.
    Copy the Search Key.
As the AWO_US_W role in AWO Front End:
  - Open the Box window and paste the Search Key. Press GO! button.

  #In this moment the modified HQL is executed#
(0120000)
hgbot   
2020-05-18 17:44   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 4c466c18fc2c4ad3ecdda5791457fa99241b2ca5
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 07 14:29:20 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/4c466c18fc2c4ad3ecdda5791457fa99241b2ca5 [^]

fixes BUG-43976:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/ReferencedInventoryProvider.java
---
(0120001)
dmiguelez   
2020-05-18 17:45   
Code Review + Testing Ok