Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0043968
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-06 15:152020-05-18 16:34
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision996ba006bc19
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0043968: Apply new HQL Style in JsonDataServiceExtraActionsTaskDeletion.java

DescriptionJsonDataServiceExtraActionsTaskDeletion.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0119658)
inigo_lerga (reporter)
2020-05-07 13:29

--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
As the AWO-QA Admin - AWO-QA role:
  - Go to the Sales Order window and set any Busines Partner desired,
    leaving the rest of the fields as default.
    Go to the Lines Tab and create a new Line with any product
    and quantity desired.
    Save and book the Sales Order.
    Press the Pick button and Done button (no need for assigned user).
  - Go to the Picking List window and find the previously created
    Picking List record.
    Delete this record.

  #In this moment the modified HQL is executed#
(0119994)
hgbot (developer)
2020-05-18 16:34

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 996ba006bc1985b1f09b6d8afbb5f74b1aa81448
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 07 09:59:13 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/996ba006bc1985b1f09b6d8afbb5f74b1aa81448 [^]

fixes BUG-43968:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/jsondataserviceextraactions/JsonDataServiceExtraActionsTaskDeletion.java
---
(0119995)
hgbot (developer)
2020-05-18 16:34

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: bc85cccf2a6204f5375f2002004fb3b38edf0723
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon May 18 16:33:54 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/bc85cccf2a6204f5375f2002004fb3b38edf0723 [^]

Related to ISSUE-43968. Removed unnecessary variable

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/jsondataserviceextraactions/JsonDataServiceExtraActionsTaskDeletion.java
---
(0119996)
dmiguelez (developer)
2020-05-18 16:34

Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-06 15:15 inigo_lerga New Issue
2020-05-06 15:15 inigo_lerga Assigned To => inigo_lerga
2020-05-06 15:16 inigo_lerga Relationship added related to 0041287
2020-05-06 15:16 inigo_lerga Status new => scheduled
2020-05-07 13:29 inigo_lerga Note Added: 0119658
2020-05-18 16:34 hgbot Checkin
2020-05-18 16:34 hgbot Note Added: 0119994
2020-05-18 16:34 hgbot Status scheduled => resolved
2020-05-18 16:34 hgbot Resolution open => fixed
2020-05-18 16:34 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/996ba006bc1985b1f09b6d8afbb5f74b1aa81448 [^]
2020-05-18 16:34 hgbot Checkin
2020-05-18 16:34 hgbot Note Added: 0119995
2020-05-18 16:34 dmiguelez Review Assigned To => dmiguelez
2020-05-18 16:34 dmiguelez Note Added: 0119996
2020-05-18 16:34 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker