Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043968ModulesAdvanced Warehouse Operationspublic2020-05-06 15:152020-05-18 16:34
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0043968: Apply new HQL Style in JsonDataServiceExtraActionsTaskDeletion.java
DescriptionJsonDataServiceExtraActionsTaskDeletion.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-06 15:15inigo_lergaNew Issue
2020-05-06 15:15inigo_lergaAssigned To => inigo_lerga
2020-05-06 15:16inigo_lergaRelationship addedrelated to 0041287
2020-05-06 15:16inigo_lergaStatusnew => scheduled
2020-05-07 13:29inigo_lergaNote Added: 0119658
2020-05-18 16:34hgbotCheckin
2020-05-18 16:34hgbotNote Added: 0119994
2020-05-18 16:34hgbotStatusscheduled => resolved
2020-05-18 16:34hgbotResolutionopen => fixed
2020-05-18 16:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/996ba006bc1985b1f09b6d8afbb5f74b1aa81448 [^]
2020-05-18 16:34hgbotCheckin
2020-05-18 16:34hgbotNote Added: 0119995
2020-05-18 16:34dmiguelezReview Assigned To => dmiguelez
2020-05-18 16:34dmiguelezNote Added: 0119996
2020-05-18 16:34dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119658)
inigo_lerga   
2020-05-07 13:29   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
As the AWO-QA Admin - AWO-QA role:
  - Go to the Sales Order window and set any Busines Partner desired,
    leaving the rest of the fields as default.
    Go to the Lines Tab and create a new Line with any product
    and quantity desired.
    Save and book the Sales Order.
    Press the Pick button and Done button (no need for assigned user).
  - Go to the Picking List window and find the previously created
    Picking List record.
    Delete this record.

  #In this moment the modified HQL is executed#
(0119994)
hgbot   
2020-05-18 16:34   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 996ba006bc1985b1f09b6d8afbb5f74b1aa81448
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 07 09:59:13 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/996ba006bc1985b1f09b6d8afbb5f74b1aa81448 [^]

fixes BUG-43968:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/jsondataserviceextraactions/JsonDataServiceExtraActionsTaskDeletion.java
---
(0119995)
hgbot   
2020-05-18 16:34   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: bc85cccf2a6204f5375f2002004fb3b38edf0723
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon May 18 16:33:54 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/bc85cccf2a6204f5375f2002004fb3b38edf0723 [^]

Related to ISSUE-43968. Removed unnecessary variable

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/jsondataserviceextraactions/JsonDataServiceExtraActionsTaskDeletion.java
---
(0119996)
dmiguelez   
2020-05-18 16:34   
Code Review + Testing Ok