Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043261
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-02-19 10:382020-03-02 12:33
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision7f06e36efe86
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043261: Apply new HQL Style in SL_LandedCost_InvoiceLine.java

DescriptionSL_LandedCost_InvoiceLine.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0117944)
inigo_lerga (viewer)
2020-02-19 13:37

 --Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
    - Go to Landed Cost Type window and create a new
      record with any Name desired, "Distribution by Amount"
      as Landed Cost Distribution Algorithm and
      "IT global services" as Product.
      Save the record.
    - Go to the Landed Cost window and create a new record.
      Go to the Cost Tab and create a new Cost record
      with the previosly created Landed Cost Type,
      "Distribution by Amount" in the Landed Cost
      Distribution Algorithm field and any Invoice Line
      that can be selected inside the field selector.
    
    #In this moment the modified HQL is executed#
(0118240)
hgbot (developer)
2020-03-02 12:32

 Repository: erp/devel/pi
Changeset: 7f06e36efe866bbcede98161f1f9d87674a78160
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Feb 19 13:16:36 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7f06e36efe866bbcede98161f1f9d87674a78160 [^]

fixes BUG-43261:Applied new HQL Style

---
M src/org/openbravo/erpCommon/ad_callouts/SL_LandedCost_InvoiceLine.java
---
(0118241)
hgbot (developer)
2020-03-02 12:32

 Repository: erp/devel/pi
Changeset: f722acf237a5cea38e4a2b6c789fd8dc0abb3e54
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Feb 19 13:28:57 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f722acf237a5cea38e4a2b6c789fd8dc0abb3e54 [^]

related to ISSUE-43261: Applied Sonarlint suggestions and more

Sonarlint suggestions applied.
Finals added.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_LandedCost_InvoiceLine.java
---
(0118242)
dmiguelez (viewer)
2020-03-02 12:33

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-02-19 10:38 inigo_lerga New Issue
2020-02-19 10:38 inigo_lerga Assigned To => inigo_lerga
2020-02-19 10:38 inigo_lerga OBNetwork customer => No
2020-02-19 10:38 inigo_lerga Modules => Core
2020-02-19 10:38 inigo_lerga Triggers an Emergency Pack => No
2020-02-19 10:38 inigo_lerga Relationship added related to 0041287
2020-02-19 10:38 inigo_lerga Status new => scheduled
2020-02-19 13:37 inigo_lerga Note Added: 0117944
2020-03-02 12:32 hgbot Checkin
2020-03-02 12:32 hgbot Note Added: 0118240
2020-03-02 12:32 hgbot Status scheduled => resolved
2020-03-02 12:32 hgbot Resolution open => fixed
2020-03-02 12:32 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7f06e36efe866bbcede98161f1f9d87674a78160 [^]
2020-03-02 12:32 hgbot Checkin
2020-03-02 12:32 hgbot Note Added: 0118241
2020-03-02 12:33 dmiguelez Review Assigned To => dmiguelez
2020-03-02 12:33 dmiguelez Note Added: 0118242
2020-03-02 12:33 dmiguelez Status resolved => closed
2020-03-02 12:33 dmiguelez Fixed in Version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker