Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043261Openbravo ERPA. Platformpublic2020-02-19 10:382020-03-02 12:33
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043261: Apply new HQL Style in SL_LandedCost_InvoiceLine.java
DescriptionSL_LandedCost_InvoiceLine.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-02-19 10:38inigo_lergaNew Issue
2020-02-19 10:38inigo_lergaAssigned To => inigo_lerga
2020-02-19 10:38inigo_lergaOBNetwork customer => No
2020-02-19 10:38inigo_lergaModules => Core
2020-02-19 10:38inigo_lergaTriggers an Emergency Pack => No
2020-02-19 10:38inigo_lergaRelationship addedrelated to 0041287
2020-02-19 10:38inigo_lergaStatusnew => scheduled
2020-02-19 13:37inigo_lergaNote Added: 0117944
2020-03-02 12:32hgbotCheckin
2020-03-02 12:32hgbotNote Added: 0118240
2020-03-02 12:32hgbotStatusscheduled => resolved
2020-03-02 12:32hgbotResolutionopen => fixed
2020-03-02 12:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7f06e36efe866bbcede98161f1f9d87674a78160 [^]
2020-03-02 12:32hgbotCheckin
2020-03-02 12:32hgbotNote Added: 0118241
2020-03-02 12:33dmiguelezReview Assigned To => dmiguelez
2020-03-02 12:33dmiguelezNote Added: 0118242
2020-03-02 12:33dmiguelezStatusresolved => closed
2020-03-02 12:33dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0117944)
inigo_lerga   
2020-02-19 13:37   
--Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
    - Go to Landed Cost Type window and create a new
      record with any Name desired, "Distribution by Amount"
      as Landed Cost Distribution Algorithm and
      "IT global services" as Product.
      Save the record.
    - Go to the Landed Cost window and create a new record.
      Go to the Cost Tab and create a new Cost record
      with the previosly created Landed Cost Type,
      "Distribution by Amount" in the Landed Cost
      Distribution Algorithm field and any Invoice Line
      that can be selected inside the field selector.
    
    #In this moment the modified HQL is executed#
(0118240)
hgbot   
2020-03-02 12:32   
Repository: erp/devel/pi
Changeset: 7f06e36efe866bbcede98161f1f9d87674a78160
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Feb 19 13:16:36 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7f06e36efe866bbcede98161f1f9d87674a78160 [^]

fixes BUG-43261:Applied new HQL Style

---
M src/org/openbravo/erpCommon/ad_callouts/SL_LandedCost_InvoiceLine.java
---
(0118241)
hgbot   
2020-03-02 12:32   
Repository: erp/devel/pi
Changeset: f722acf237a5cea38e4a2b6c789fd8dc0abb3e54
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Feb 19 13:28:57 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f722acf237a5cea38e4a2b6c789fd8dc0abb3e54 [^]

related to ISSUE-43261: Applied Sonarlint suggestions and more

Sonarlint suggestions applied.
Finals added.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_LandedCost_InvoiceLine.java
---
(0118242)
dmiguelez   
2020-03-02 12:33   
Code Review + Testing Ok