Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0042877
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-01-15 09:332020-01-20 18:09
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision0822e963493d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042877: Apply new HQL Style in UpdateInvoiceLineInformation.java

DescriptionUpdateInvoiceLineInformation.java has two HQL queries with:
- the HQL is hard to read because of formatting
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0116886)
inigo_lerga (viewer)
2020-01-15 10:14

 Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Sales Order window and create
      a new record with "Alimentos y Supermercados, S.A"
      as Business Partner, and Invoice Terms field as
      "Immediate".
    - Go to the Lines Tab and create a new record with
      "Cerveza Ale 0,5L" product with 70 in the
      Ordered Quantity field.
    - Press the Book button and then OK button in the
      popup window.
    - Go to the Sales Invoice window and create a new
      record with "Alimentos y Supermercados, S.A" as
      Business Partner. Then press the Create Lines
      From Order button and select all the lines from
      the Sales Order previously created. Press the
      Done button.
      
#In this moment the modified HQL is executed#
(0117093)
dmiguelez (viewer)
2020-01-20 18:08

 Test Plan II

Follow the same steps for Purchase flow
Purchase Order - Purchase Invoice
Any Business Partner, any Product
(0117094)
hgbot (developer)
2020-01-20 18:09

 Repository: erp/devel/pi
Changeset: 0822e963493dfa145df9d86a85fe2fa082ce0fdb
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Jan 15 10:15:21 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0822e963493dfa145df9d86a85fe2fa082ce0fdb [^]

fixes BUG-42877:Applied new HQL Style

---
M src/org/openbravo/common/actionhandler/createlinesfromprocess/UpdateInvoiceLineInformation.java
---
(0117095)
hgbot (developer)
2020-01-20 18:09

 Repository: erp/devel/pi
Changeset: 3bcc0189fd3dc42bb87558ec697b8caec91b009b
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Jan 15 12:07:51 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3bcc0189fd3dc42bb87558ec697b8caec91b009b [^]

related to ISSUE-42877: Copyright date updated

---
M src/org/openbravo/common/actionhandler/createlinesfromprocess/UpdateInvoiceLineInformation.java
---
(0117096)
hgbot (developer)
2020-01-20 18:09

 Repository: erp/devel/pi
Changeset: 57ba52e52dfc1e73c0d0293a7ac8962a8bca8ff9
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jan 20 18:08:57 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/57ba52e52dfc1e73c0d0293a7ac8962a8bca8ff9 [^]

Related to ISSUE-42877. Code Review Changes
* Do not use property navigation, explicitly use the property name
  in the hql query

---
M src/org/openbravo/common/actionhandler/createlinesfromprocess/UpdateInvoiceLineInformation.java
---
(0117097)
dmiguelez (viewer)
2020-01-20 18:09

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-01-15 09:33 inigo_lerga New Issue
2020-01-15 09:33 inigo_lerga Assigned To => inigo_lerga
2020-01-15 09:33 inigo_lerga OBNetwork customer => No
2020-01-15 09:33 inigo_lerga Modules => Core
2020-01-15 09:33 inigo_lerga Triggers an Emergency Pack => No
2020-01-15 09:33 inigo_lerga Relationship added related to 0041287
2020-01-15 09:35 inigo_lerga Status new => scheduled
2020-01-15 10:14 inigo_lerga Note Added: 0116886
2020-01-20 18:08 dmiguelez Note Added: 0117093
2020-01-20 18:09 hgbot Checkin
2020-01-20 18:09 hgbot Note Added: 0117094
2020-01-20 18:09 hgbot Status scheduled => resolved
2020-01-20 18:09 hgbot Resolution open => fixed
2020-01-20 18:09 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0822e963493dfa145df9d86a85fe2fa082ce0fdb [^]
2020-01-20 18:09 hgbot Checkin
2020-01-20 18:09 hgbot Note Added: 0117095
2020-01-20 18:09 hgbot Checkin
2020-01-20 18:09 hgbot Note Added: 0117096
2020-01-20 18:09 dmiguelez Review Assigned To => dmiguelez
2020-01-20 18:09 dmiguelez Note Added: 0117097
2020-01-20 18:09 dmiguelez Status resolved => closed
2020-01-20 18:09 dmiguelez Fixed in Version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker