Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042877Openbravo ERPA. Platformpublic2020-01-15 09:332020-01-20 18:09
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042877: Apply new HQL Style in UpdateInvoiceLineInformation.java
DescriptionUpdateInvoiceLineInformation.java has two HQL queries with:
- the HQL is hard to read because of formatting
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-15 09:33inigo_lergaNew Issue
2020-01-15 09:33inigo_lergaAssigned To => inigo_lerga
2020-01-15 09:33inigo_lergaOBNetwork customer => No
2020-01-15 09:33inigo_lergaModules => Core
2020-01-15 09:33inigo_lergaTriggers an Emergency Pack => No
2020-01-15 09:33inigo_lergaRelationship addedrelated to 0041287
2020-01-15 09:35inigo_lergaStatusnew => scheduled
2020-01-15 10:14inigo_lergaNote Added: 0116886
2020-01-20 18:08dmiguelezNote Added: 0117093
2020-01-20 18:09hgbotCheckin
2020-01-20 18:09hgbotNote Added: 0117094
2020-01-20 18:09hgbotStatusscheduled => resolved
2020-01-20 18:09hgbotResolutionopen => fixed
2020-01-20 18:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0822e963493dfa145df9d86a85fe2fa082ce0fdb [^]
2020-01-20 18:09hgbotCheckin
2020-01-20 18:09hgbotNote Added: 0117095
2020-01-20 18:09hgbotCheckin
2020-01-20 18:09hgbotNote Added: 0117096
2020-01-20 18:09dmiguelezReview Assigned To => dmiguelez
2020-01-20 18:09dmiguelezNote Added: 0117097
2020-01-20 18:09dmiguelezStatusresolved => closed
2020-01-20 18:09dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0116886)
inigo_lerga   
2020-01-15 10:14   
Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Sales Order window and create
      a new record with "Alimentos y Supermercados, S.A"
      as Business Partner, and Invoice Terms field as
      "Immediate".
    - Go to the Lines Tab and create a new record with
      "Cerveza Ale 0,5L" product with 70 in the
      Ordered Quantity field.
    - Press the Book button and then OK button in the
      popup window.
    - Go to the Sales Invoice window and create a new
      record with "Alimentos y Supermercados, S.A" as
      Business Partner. Then press the Create Lines
      From Order button and select all the lines from
      the Sales Order previously created. Press the
      Done button.
      
#In this moment the modified HQL is executed#
(0117093)
dmiguelez   
2020-01-20 18:08   
Test Plan II

Follow the same steps for Purchase flow
Purchase Order - Purchase Invoice
Any Business Partner, any Product
(0117094)
hgbot   
2020-01-20 18:09   
Repository: erp/devel/pi
Changeset: 0822e963493dfa145df9d86a85fe2fa082ce0fdb
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Jan 15 10:15:21 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0822e963493dfa145df9d86a85fe2fa082ce0fdb [^]

fixes BUG-42877:Applied new HQL Style

---
M src/org/openbravo/common/actionhandler/createlinesfromprocess/UpdateInvoiceLineInformation.java
---
(0117095)
hgbot   
2020-01-20 18:09   
Repository: erp/devel/pi
Changeset: 3bcc0189fd3dc42bb87558ec697b8caec91b009b
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Jan 15 12:07:51 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3bcc0189fd3dc42bb87558ec697b8caec91b009b [^]

related to ISSUE-42877: Copyright date updated

---
M src/org/openbravo/common/actionhandler/createlinesfromprocess/UpdateInvoiceLineInformation.java
---
(0117096)
hgbot   
2020-01-20 18:09   
Repository: erp/devel/pi
Changeset: 57ba52e52dfc1e73c0d0293a7ac8962a8bca8ff9
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jan 20 18:08:57 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/57ba52e52dfc1e73c0d0293a7ac8962a8bca8ff9 [^]

Related to ISSUE-42877. Code Review Changes
* Do not use property navigation, explicitly use the property name
  in the hql query

---
M src/org/openbravo/common/actionhandler/createlinesfromprocess/UpdateInvoiceLineInformation.java
---
(0117097)
dmiguelez   
2020-01-20 18:09   
Code Review + Testing Ok