Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0042816
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-01-13 12:452020-01-17 14:37
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision8e967c22d483
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042816: Apply new HQL Style in FIN_BankStatementProcess.java

DescriptionFIN_BankStatementProcess.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0116832)
inigo_lerga (reporter)
2020-01-14 10:32

 Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Financial Account window
      and enter the "Cuenta de Banco" record.
      Enter the Imported Bank Statements tab
      and select the most recent one.
      Press the reactivate button and Ok button
      inside the popup window.
      Now press the Process button and Ok button
      inside the popup window.
      
#In this moment the modified HQL is executed#
(0117029)
hgbot (developer)
2020-01-17 14:37

 Repository: erp/devel/pi
Changeset: 8e967c22d48322913cc6b3c7f22f9ac65e73b8f8
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Jan 14 10:03:49 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8e967c22d48322913cc6b3c7f22f9ac65e73b8f8 [^]

fixes BUG-42816:Applied new HQL Style

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_BankStatementProcess.java
---
(0117030)
hgbot (developer)
2020-01-17 14:37

 Repository: erp/devel/pi
Changeset: 95c3147aa768da58e052000c488e7405eca4585c
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Jan 14 10:17:11 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/95c3147aa768da58e052000c488e7405eca4585c [^]

related to ISSUE-42816: Applied Sonarlint suggestions

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_BankStatementProcess.java
---
(0117031)
hgbot (developer)
2020-01-17 14:37

 Repository: erp/devel/pi
Changeset: 69fe71ead208b695ca61a2022acc32dbeb7460cf
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jan 17 14:36:52 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/69fe71ead208b695ca61a2022acc32dbeb7460cf [^]

Related to ISSUE-42816: Code Review Changes:
* Use id instead of object in query

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_BankStatementProcess.java
---
(0117032)
dmiguelez (developer)
2020-01-17 14:37

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-01-13 12:45 inigo_lerga New Issue
2020-01-13 12:45 inigo_lerga Assigned To => inigo_lerga
2020-01-13 12:45 inigo_lerga Modules => Core
2020-01-13 12:45 inigo_lerga Triggers an Emergency Pack => No
2020-01-13 12:45 inigo_lerga Status new => scheduled
2020-01-13 12:45 inigo_lerga Relationship added related to 0041287
2020-01-14 10:32 inigo_lerga Note Added: 0116832
2020-01-17 14:37 hgbot Checkin
2020-01-17 14:37 hgbot Note Added: 0117029
2020-01-17 14:37 hgbot Status scheduled => resolved
2020-01-17 14:37 hgbot Resolution open => fixed
2020-01-17 14:37 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8e967c22d48322913cc6b3c7f22f9ac65e73b8f8 [^]
2020-01-17 14:37 hgbot Checkin
2020-01-17 14:37 hgbot Note Added: 0117030
2020-01-17 14:37 hgbot Checkin
2020-01-17 14:37 hgbot Note Added: 0117031
2020-01-17 14:37 dmiguelez Review Assigned To => dmiguelez
2020-01-17 14:37 dmiguelez Note Added: 0117032
2020-01-17 14:37 dmiguelez Status resolved => closed
2020-01-17 14:37 dmiguelez Fixed in Version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker