Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042816Openbravo ERPA. Platformpublic2020-01-13 12:452020-01-17 14:37
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042816: Apply new HQL Style in FIN_BankStatementProcess.java
DescriptionFIN_BankStatementProcess.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-13 12:45inigo_lergaNew Issue
2020-01-13 12:45inigo_lergaAssigned To => inigo_lerga
2020-01-13 12:45inigo_lergaModules => Core
2020-01-13 12:45inigo_lergaTriggers an Emergency Pack => No
2020-01-13 12:45inigo_lergaStatusnew => scheduled
2020-01-13 12:45inigo_lergaRelationship addedrelated to 0041287
2020-01-14 10:32inigo_lergaNote Added: 0116832
2020-01-17 14:37hgbotCheckin
2020-01-17 14:37hgbotNote Added: 0117029
2020-01-17 14:37hgbotStatusscheduled => resolved
2020-01-17 14:37hgbotResolutionopen => fixed
2020-01-17 14:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8e967c22d48322913cc6b3c7f22f9ac65e73b8f8 [^]
2020-01-17 14:37hgbotCheckin
2020-01-17 14:37hgbotNote Added: 0117030
2020-01-17 14:37hgbotCheckin
2020-01-17 14:37hgbotNote Added: 0117031
2020-01-17 14:37dmiguelezReview Assigned To => dmiguelez
2020-01-17 14:37dmiguelezNote Added: 0117032
2020-01-17 14:37dmiguelezStatusresolved => closed
2020-01-17 14:37dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0116832)
inigo_lerga   
2020-01-14 10:32   
Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Financial Account window
      and enter the "Cuenta de Banco" record.
      Enter the Imported Bank Statements tab
      and select the most recent one.
      Press the reactivate button and Ok button
      inside the popup window.
      Now press the Process button and Ok button
      inside the popup window.
      
#In this moment the modified HQL is executed#
(0117029)
hgbot   
2020-01-17 14:37   
Repository: erp/devel/pi
Changeset: 8e967c22d48322913cc6b3c7f22f9ac65e73b8f8
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Jan 14 10:03:49 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8e967c22d48322913cc6b3c7f22f9ac65e73b8f8 [^]

fixes BUG-42816:Applied new HQL Style

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_BankStatementProcess.java
---
(0117030)
hgbot   
2020-01-17 14:37   
Repository: erp/devel/pi
Changeset: 95c3147aa768da58e052000c488e7405eca4585c
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Jan 14 10:17:11 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/95c3147aa768da58e052000c488e7405eca4585c [^]

related to ISSUE-42816: Applied Sonarlint suggestions

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_BankStatementProcess.java
---
(0117031)
hgbot   
2020-01-17 14:37   
Repository: erp/devel/pi
Changeset: 69fe71ead208b695ca61a2022acc32dbeb7460cf
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jan 17 14:36:52 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/69fe71ead208b695ca61a2022acc32dbeb7460cf [^]

Related to ISSUE-42816: Code Review Changes:
* Use id instead of object in query

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_BankStatementProcess.java
---
(0117032)
dmiguelez   
2020-01-17 14:37   
Code Review + Testing Ok