0042217: [19Q4] [UX] Incorrectly configured Gift Certificate payment method error message is incorrect

Description

The error popup that appears in the POS when the Gift Certificate payment method is incorrectly configured shows an incorrect message.

Steps To Reproduce

PRECONDITION: the "Gift Cards and Gift Vouchers" module must be installed

-- In the POS
0. Log in the PS-1 terminal as user "posets"
1. Click on the Create Gift Certificate button
NOTICE that the error popup appears as depicted in the attachment with the incorrect message. There's no such thing as "Gift Card payment method"

Proposed Solution

During the QA cycle, the main reason for the error popup to arise was the incorrect Search Key used in the Touchpoint Type Payment Method, and in the Touchpoint Payment Type. The message should hint this misconfiguration issue as a possible solution.

****************************
* Attached fix proposal *
****************************

Tags

No tags attached.

Attached Files

gift-cert-create-error-incorrect.png [^] (66,529 bytes) 2019-11-07 10:47

issue42217_incorrectErrorMessage_giftcards.patch [^] (2,911 bytes) 2021-11-18 13:18 [Show Content] [Hide Content]

From ca5f5fc60d399a560d8470b7e844460f4e20c20b Mon Sep 17 00:00:00 2001
From: beatriz_lago <beatrizlago@openbravo.com>
Date: Thu, 7 Oct 2021 09:21:40 +0200
Subject: [PATCH] Fixed ISSUE-42217: Incorrectly configured Gift Certificate
 payment method error message is incorrect Changed the message to a more
 accurate one.

---
 src-db/database/sourcedata/AD_MESSAGE.xml            | 12 ++++++++++++
 .../js/components/GiftCardMenu.js                    |  2 +-
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/src-db/database/sourcedata/AD_MESSAGE.xml b/src-db/database/sourcedata/AD_MESSAGE.xml
index 13c4632..938a95c 100644
--- a/src-db/database/sourcedata/AD_MESSAGE.xml
+++ b/src-db/database/sourcedata/AD_MESSAGE.xml
@@ -888,6 +888,18 @@
 <!--7A3F736BA309471E940562BA17F44C40-->  <ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N>
 <!--7A3F736BA309471E940562BA17F44C40--></AD_MESSAGE>
 
+<!--7A5E0A6A80C640C1911783457A32D89A--><AD_MESSAGE>
+<!--7A5E0A6A80C640C1911783457A32D89A-->  <AD_MESSAGE_ID><![CDATA[7A5E0A6A80C640C1911783457A32D89A]]></AD_MESSAGE_ID>
+<!--7A5E0A6A80C640C1911783457A32D89A-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
+<!--7A5E0A6A80C640C1911783457A32D89A-->  <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
+<!--7A5E0A6A80C640C1911783457A32D89A-->  <ISACTIVE><![CDATA[Y]]></ISACTIVE>
+<!--7A5E0A6A80C640C1911783457A32D89A-->  <VALUE><![CDATA[GCNV_CreateGiftCardError]]></VALUE>
+<!--7A5E0A6A80C640C1911783457A32D89A-->  <MSGTEXT><![CDATA[The Gift Card isn't configured in this terminal. It could be caused by a misconfiguration in the Search Key. Make sure the field is correctly set in Touchpoint Type Payment Method and Touchpoint Payment Type.]]></MSGTEXT>
+<!--7A5E0A6A80C640C1911783457A32D89A-->  <MSGTYPE><![CDATA[E]]></MSGTYPE>
+<!--7A5E0A6A80C640C1911783457A32D89A-->  <AD_MODULE_ID><![CDATA[17B5337C4B1948DF857B12FD3ABE5094]]></AD_MODULE_ID>
+<!--7A5E0A6A80C640C1911783457A32D89A-->  <ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N>
+<!--7A5E0A6A80C640C1911783457A32D89A--></AD_MESSAGE>
+
 <!--7B0AC1CC1E5749F8A7D4F7846CC21D38--><AD_MESSAGE>
 <!--7B0AC1CC1E5749F8A7D4F7846CC21D38-->  <AD_MESSAGE_ID><![CDATA[7B0AC1CC1E5749F8A7D4F7846CC21D38]]></AD_MESSAGE_ID>
 <!--7B0AC1CC1E5749F8A7D4F7846CC21D38-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
diff --git a/web/org.openbravo.retail.giftcards/js/components/GiftCardMenu.js b/web/org.openbravo.retail.giftcards/js/components/GiftCardMenu.js
index 9d6f047..ed570d2 100644
--- a/web/org.openbravo.retail.giftcards/js/components/GiftCardMenu.js
+++ b/web/org.openbravo.retail.giftcards/js/components/GiftCardMenu.js
@@ -109,7 +109,7 @@
       if (!giftcardPayment) {
         OB.UTIL.showConfirmation.display(
           OB.I18N.getLabel('OBMOBC_Error'),
-          OB.I18N.getLabel('GCNV_GiftCardPaymentNotConfigured')
+          OB.I18N.getLabel('GCNV_CreateGiftCardError')
         );
         return;
       }
-- 
GitLab

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2019-11-07 10:47	inaki_garcia	New Issue
2019-11-07 10:47	inaki_garcia	Assigned To	=> Retail
2019-11-07 10:47	inaki_garcia	File Added: gift-cert-create-error-incorrect.png
2019-11-07 10:47	inaki_garcia	OBNetwork customer	=> No
2019-11-07 10:47	inaki_garcia	Triggers an Emergency Pack	=> No
2019-11-07 10:49	inaki_garcia	Steps to Reproduce Updated	View Revisions
2019-11-07 11:01	inaki_garcia	Issue cloned	0042218
2019-11-12 10:05	inaki_garcia	Description Updated	View Revisions
2019-11-12 10:05	inaki_garcia	Proposed Solution updated
2019-11-12 10:06	inaki_garcia	Proposed Solution updated
2021-11-18 13:18	beatriz_lago	Status	new => acknowledged
2021-11-18 13:18	beatriz_lago	File Added: issue42217_incorrectErrorMessage_giftcards.patch
2021-11-18 13:18	beatriz_lago	Note Added: 0133172
2021-11-18 13:19	beatriz_lago	Note Deleted: 0133172
2021-11-18 13:19	beatriz_lago	Proposed Solution updated