0041713: Subquery in getDocumentNo in ReportGeneralLedgerJournal is not using bind-params

Description

Subquery in getDocumentNo in ReportGeneralLedgerJournal is not using bind-params

final String existsSubQuery = "( select 1 "
+ " from " + tablename + " dt "
+ " where f.record_id = dt." + tablename + "_id"
+ " and dt.documentno = '" + documentNo + "' )";

Steps To Reproduce

Test Plan
Go to Journal Entries Report and set:
    Organization: Region Norte
    General Ledger: F&B España
    From: 01-07-2018
    To: 24-07-2019
    From Account: (43000) Clientes (euros) a corto plazo
    To Account: (47700) Hacienda Pública IVA repercutido
    Document: AR Invoice
    DocumentNo: 1000259

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0041711

closed

collazoandy4

Subquery in getDocumentNo in ReportGeneralLedgerJournal is not using bind-params

Notes
(0114392) hgbot (developer) 2019-09-04 11:06	Repository: erp/backports/3.0PR19Q2.3 Changeset: e600ee120239c80f34d28fd3b25c0f0404605f73 Author: Armaignac <collazoandy4 <at> gmail.com> Date: Wed Sep 04 01:30:40 2019 -0400 URL: http://code.openbravo.com/erp/backports/3.0PR19Q2.3/rev/e600ee120239c80f34d28fd3b25c0f0404605f73 [^] Fixes issue 41713: Subquery in getDocumentNo in ReportGeneralLedgerJournal is not using bind-params Added the missing bind-params Now all documents id with the same documentNo is used to filter the accounting records --- M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal_data.xsql ---

(0114396) Sandrahuguet (viewer) 2019-09-04 11:09	code review + testing ok

Issue History
Date Modified	Username	Field	Change
2019-08-28 13:40	Sandrahuguet	Type	defect => backport
2019-08-28 13:40	Sandrahuguet	Target Version	=> 3.0PR19Q2.3
2019-09-04 11:06	hgbot	Checkin
2019-09-04 11:06	hgbot	Note Added: 0114392
2019-09-04 11:06	hgbot	Status	scheduled => resolved
2019-09-04 11:06	hgbot	Resolution	open => fixed
2019-09-04 11:06	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/backports/3.0PR19Q2.3/rev/e600ee120239c80f34d28fd3b25c0f0404605f73 [^]
2019-09-04 11:09	Sandrahuguet	Review Assigned To	=> Sandrahuguet
2019-09-04 11:09	Sandrahuguet	Note Added: 0114396
2019-09-04 11:09	Sandrahuguet	Status	resolved => closed
2019-09-04 11:09	Sandrahuguet	Fixed in Version	=> 3.0PR19Q2.3