Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0041713Openbravo ERP09. Financial managementpublic2019-08-28 13:332019-09-04 11:09
Sandrahuguet 
Triage Finance 
normalmajoralways
closedfixed 
30Openbravo Appliance 14.04
 
3.0PR19Q2.33.0PR19Q2.3 
Sandrahuguet
Core
No
0041713: Subquery in getDocumentNo in ReportGeneralLedgerJournal is not using bind-params
Subquery in getDocumentNo in ReportGeneralLedgerJournal is not using bind-params

final String existsSubQuery = "( select 1 "
+ " from " + tablename + " dt "
+ " where f.record_id = dt." + tablename + "_id"
+ " and dt.documentno = '" + documentNo + "' )";
Test Plan
Go to Journal Entries Report and set:
    Organization: Region Norte
    General Ledger: F&B España
    From: 01-07-2018
    To: 24-07-2019
    From Account: (43000) Clientes (euros) a corto plazo
    To Account: (47700) Hacienda Pública IVA repercutido
    Document: AR Invoice
    DocumentNo: 1000259
No tags attached.
blocks defect 0041711 closed collazoandy4 Subquery in getDocumentNo in ReportGeneralLedgerJournal is not using bind-params 
Issue History
2019-08-28 13:40SandrahuguetTypedefect => backport
2019-08-28 13:40SandrahuguetTarget Version => 3.0PR19Q2.3
2019-09-04 11:06hgbotCheckin
2019-09-04 11:06hgbotNote Added: 0114392
2019-09-04 11:06hgbotStatusscheduled => resolved
2019-09-04 11:06hgbotResolutionopen => fixed
2019-09-04 11:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q2.3/rev/e600ee120239c80f34d28fd3b25c0f0404605f73 [^]
2019-09-04 11:09SandrahuguetReview Assigned To => Sandrahuguet
2019-09-04 11:09SandrahuguetNote Added: 0114396
2019-09-04 11:09SandrahuguetStatusresolved => closed
2019-09-04 11:09SandrahuguetFixed in Version => 3.0PR19Q2.3

Notes
(0114392)
hgbot   
2019-09-04 11:06   
Repository: erp/backports/3.0PR19Q2.3
Changeset: e600ee120239c80f34d28fd3b25c0f0404605f73
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Wed Sep 04 01:30:40 2019 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR19Q2.3/rev/e600ee120239c80f34d28fd3b25c0f0404605f73 [^]

Fixes issue 41713: Subquery in getDocumentNo in ReportGeneralLedgerJournal is
not using bind-params

Added the missing bind-params
Now all documents id with the same documentNo is used to filter the accounting records

---
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal_data.xsql
---
(0114396)
Sandrahuguet   
2019-09-04 11:09   
code review + testing ok