Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041320
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminorhave not tried2019-07-08 20:522019-07-26 09:42
ReporterAtulOpenbravoView Statuspublic 
Assigned ToAtulOpenbravo 
PrioritynormalResolutionfixedFixed in Version3.0PR19Q4
StatusclosedFix in branchFixed in SCM revision9323caf4d782
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tovmromanos
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041320: API Change: Remove Old Payment Monitor used in Openbravo 2.50

DescriptionDelete Old Payment Monitor used in Openbravo 2.50 consists of below candidates removal.

- Remove AD_PROCESS for PaymentMonitor & InvoicePaymentMonitor
- Remove AD_MODEL_OBJECT, AD_MODEL_OBJECT_MAPPING for InvoicePaymentMonitor
- Remove java class for PaymentMonitor, PaymentMonitorProcess, InvoicePaymentMonitor, InvoicePaymentMonitor.html, InvoicePaymentMonitor.xml
- Remove UPDATEPAYMENTMONITOR column from table C_INVOICE, AD_FIELD used in Purchase and Sales Invoice Header Tab, its AD_COLUMN & AD_ELEMENT record, deletes PROPERTY_UPDATEPAYMENTMONITOR property, isUpdatePaymentMonitor() & setUpdatePaymentMonitor() method of Invoice class.

The risk of this change is very low as Update Payment Monitor button in Sales / Purchase Invoice header is not used because of display logic based on a preference PaymentMonitor having value '' and Processed='Y' but it is set with value as Yes. so the condition is never met. Hence the class PaymentMonitor and classes InvoicePaymentMonitor, PaymentMonitorProcess using PaymentMonitor method is not used anymore so the fields in Sales/Purchase Invoice header tab is safe to remove. Column UPDATEPAYMENTMONITOR from C_Invoice could be safely removed by managing removal of its values in Sample Data (Core, AWO, Retail).
Steps To Reproduce-
TagsApproved
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks feature request 0041081 closedAtulOpenbravo Delete old Payment Monitor (pre-APRM) 

-  Notes
(0113634)
hgbot (developer)
2019-07-24 21:41

 Repository: erp/devel/api-checks
Changeset: 9323caf4d782977c7453ddd1e71a9faa5a27dc5c
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu Jul 25 00:52:51 2019 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/9323caf4d782977c7453ddd1e71a9faa5a27dc5c [^]

Fixes Issue 0041320: API Change: Remove Old Payment Monitor used
in Openbravo 2.50

**Removed UpdatePaymentMonitor column from C_INVOICE
**Removed reference from AD_COLUMN
**Removed reference from AD_FIELD
**Removed reference from Model Object & its Mapping
**Removed reference from AD_PROCESS & its Text Interfaces
**Removed reference from AD_ELEMENT
**Removed class InvoicePaymentMonitor, PaymentMonitor,
PaymentMonitorProcess, PROPERTY_UPDATEPAYMENTMONITOR, method
isUpdatePaymentMonitor & setUpdatePaymentMonitor of Invoice

---
M java/reference/java.japi.gz
M model/src-db/database/model/tables/C_INVOICE.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_ELEMENT.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M model/src-db/database/sourcedata/AD_PROCESS.xml
M model/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
---
(0113671)
vmromanos (manager)
2019-07-26 09:42

 CI passed successfully

- Issue History
Date Modified Username Field Change
2019-07-08 20:52 AtulOpenbravo New Issue
2019-07-08 20:52 AtulOpenbravo Assigned To => Triage Finance
2019-07-08 20:52 AtulOpenbravo Modules => Core
2019-07-08 20:52 AtulOpenbravo Triggers an Emergency Pack => No
2019-07-08 21:29 AtulOpenbravo Description Updated View Revisions
2019-07-09 09:37 AtulOpenbravo Relationship added blocks 0041081
2019-07-09 13:02 AtulOpenbravo Assigned To Triage Finance => dmitry_mezentsev
2019-07-09 17:49 dmitry_mezentsev Tag Attached: Approved
2019-07-09 17:49 dmitry_mezentsev Assigned To dmitry_mezentsev => AtulOpenbravo
2019-07-23 15:36 vmromanos Status new => scheduled
2019-07-24 21:41 hgbot Checkin
2019-07-24 21:41 hgbot Note Added: 0113634
2019-07-24 21:41 hgbot Status scheduled => resolved
2019-07-24 21:41 hgbot Resolution open => fixed
2019-07-24 21:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/9323caf4d782977c7453ddd1e71a9faa5a27dc5c [^]
2019-07-26 09:42 vmromanos Review Assigned To => vmromanos
2019-07-26 09:42 vmromanos Note Added: 0113671
2019-07-26 09:42 vmromanos Status resolved => closed
2019-07-26 09:42 vmromanos Fixed in Version => 3.0PR19Q4

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker