Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041320Openbravo ERP09. Financial managementpublic2019-07-08 20:522019-07-26 09:42
ReporterAtulOpenbravo 
Assigned ToAtulOpenbravo 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041320: API Change: Remove Old Payment Monitor used in Openbravo 2.50
DescriptionDelete Old Payment Monitor used in Openbravo 2.50 consists of below candidates removal.

- Remove AD_PROCESS for PaymentMonitor & InvoicePaymentMonitor
- Remove AD_MODEL_OBJECT, AD_MODEL_OBJECT_MAPPING for InvoicePaymentMonitor
- Remove java class for PaymentMonitor, PaymentMonitorProcess, InvoicePaymentMonitor, InvoicePaymentMonitor.html, InvoicePaymentMonitor.xml
- Remove UPDATEPAYMENTMONITOR column from table C_INVOICE, AD_FIELD used in Purchase and Sales Invoice Header Tab, its AD_COLUMN & AD_ELEMENT record, deletes PROPERTY_UPDATEPAYMENTMONITOR property, isUpdatePaymentMonitor() & setUpdatePaymentMonitor() method of Invoice class.

The risk of this change is very low as Update Payment Monitor button in Sales / Purchase Invoice header is not used because of display logic based on a preference PaymentMonitor having value '' and Processed='Y' but it is set with value as Yes. so the condition is never met. Hence the class PaymentMonitor and classes InvoicePaymentMonitor, PaymentMonitorProcess using PaymentMonitor method is not used anymore so the fields in Sales/Purchase Invoice header tab is safe to remove. Column UPDATEPAYMENTMONITOR from C_Invoice could be safely removed by managing removal of its values in Sample Data (Core, AWO, Retail).
Steps To Reproduce-
Proposed Solution
Additional Information
TagsApproved
Relationships
blocks feature request 0041081 closed AtulOpenbravo Delete old Payment Monitor (pre-APRM) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-08 20:52AtulOpenbravoNew Issue
2019-07-08 20:52AtulOpenbravoAssigned To => Triage Finance
2019-07-08 20:52AtulOpenbravoModules => Core
2019-07-08 20:52AtulOpenbravoTriggers an Emergency Pack => No
2019-07-08 21:29AtulOpenbravoDescription Updatedbug_revision_view_page.php?rev_id=19068#r19068
2019-07-09 09:37AtulOpenbravoRelationship addedblocks 0041081
2019-07-09 13:02AtulOpenbravoAssigned ToTriage Finance => dmitry_mezentsev
2019-07-09 17:49dmitry_mezentsevTag Attached: Approved
2019-07-09 17:49dmitry_mezentsevAssigned Todmitry_mezentsev => AtulOpenbravo
2019-07-23 15:36vmromanosStatusnew => scheduled
2019-07-24 21:41hgbotCheckin
2019-07-24 21:41hgbotNote Added: 0113634
2019-07-24 21:41hgbotStatusscheduled => resolved
2019-07-24 21:41hgbotResolutionopen => fixed
2019-07-24 21:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/9323caf4d782977c7453ddd1e71a9faa5a27dc5c [^]
2019-07-26 09:42vmromanosReview Assigned To => vmromanos
2019-07-26 09:42vmromanosNote Added: 0113671
2019-07-26 09:42vmromanosStatusresolved => closed
2019-07-26 09:42vmromanosFixed in Version => 3.0PR19Q4

Notes
(0113634)
hgbot   
2019-07-24 21:41   
Repository: erp/devel/api-checks
Changeset: 9323caf4d782977c7453ddd1e71a9faa5a27dc5c
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu Jul 25 00:52:51 2019 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/9323caf4d782977c7453ddd1e71a9faa5a27dc5c [^]

Fixes Issue 0041320: API Change: Remove Old Payment Monitor used
in Openbravo 2.50

**Removed UpdatePaymentMonitor column from C_INVOICE
**Removed reference from AD_COLUMN
**Removed reference from AD_FIELD
**Removed reference from Model Object & its Mapping
**Removed reference from AD_PROCESS & its Text Interfaces
**Removed reference from AD_ELEMENT
**Removed class InvoicePaymentMonitor, PaymentMonitor,
PaymentMonitorProcess, PROPERTY_UPDATEPAYMENTMONITOR, method
isUpdatePaymentMonitor & setUpdatePaymentMonitor of Invoice

---
M java/reference/java.japi.gz
M model/src-db/database/model/tables/C_INVOICE.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_ELEMENT.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M model/src-db/database/sourcedata/AD_PROCESS.xml
M model/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
---
(0113671)
vmromanos   
2019-07-26 09:42   
CI passed successfully