0041256: ReportProjectProfitabilityJR.noConversionToHours is not using bind-params

Description

This code is not using bind-params:

    if (StringUtils.isNotEmpty(strOrg)) {
      hsqlScript.append(" and p." + Project.PROPERTY_ORGANIZATION + ".id in (" + strOrg + ")");
    }

When fixing please apply new HQL-style to every HQL in this file.

Steps To Reproduce

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0041253

3.0PR19Q4

closed

AtulOpenbravo

ReportProjectProfitabilityJR.noConversionToHours is not using bind-params

Notes
(0113470) hgbot (developer) 2019-07-17 11:26	Repository: erp/backports/3.0PR19Q1.3 Changeset: 0d3ff7b92273929ffbbe8b331b8f3f432d43379c Author: Atul Gaware <atul.gaware <at> openbravo.com> Date: Mon Jul 15 18:15:38 2019 +0530 URL: http://code.openbravo.com/erp/backports/3.0PR19Q1.3/rev/0d3ff7b92273929ffbbe8b331b8f3f432d43379c [^] Fixes Issue 41256: ReportProjectProfitabilityJR.noConversionToHours is not using bind-params Applied bind-params to organization ids in noConversionToHours method. Organization ids are obtained from OrganizationStructureProvider --- M src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.java ---

(0113474) dmiguelez (developer) 2019-07-17 11:27	Code Review + Testing Ok

Issue History
Date Modified	Username	Field	Change
2019-07-03 16:53	shuehner	Type	defect => backport
2019-07-03 16:53	shuehner	Target Version	=> 3.0PR19Q1.2
2019-07-09 18:19	shuehner	Target Version	3.0PR19Q1.2 => 3.0PR19Q1.3
2019-07-17 11:26	hgbot	Checkin
2019-07-17 11:26	hgbot	Note Added: 0113470
2019-07-17 11:26	hgbot	Status	scheduled => resolved
2019-07-17 11:26	hgbot	Resolution	open => fixed
2019-07-17 11:26	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/backports/3.0PR19Q1.3/rev/0d3ff7b92273929ffbbe8b331b8f3f432d43379c [^]
2019-07-17 11:27	dmiguelez	Review Assigned To	=> dmiguelez
2019-07-17 11:27	dmiguelez	Note Added: 0113474
2019-07-17 11:27	dmiguelez	Status	resolved => closed
2019-07-17 11:27	dmiguelez	Fixed in Version	=> 3.0PR19Q1.3