Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041256Openbravo ERP08. Project and service managementpublic2019-07-03 16:522019-07-17 11:27
Reportershuehner 
Assigned ToTriage Omni OMS 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q1.3Fixed in Version3.0PR19Q1.3 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041256: ReportProjectProfitabilityJR.noConversionToHours is not using bind-params
DescriptionThis code is not using bind-params:

    if (StringUtils.isNotEmpty(strOrg)) {
      hsqlScript.append(" and p." + Project.PROPERTY_ORGANIZATION + ".id in (" + strOrg + ")");
    }

When fixing please apply new HQL-style to every HQL in this file.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00412533.0PR19Q4 closed AtulOpenbravo ReportProjectProfitabilityJR.noConversionToHours is not using bind-params 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-03 16:53shuehnerTypedefect => backport
2019-07-03 16:53shuehnerTarget Version => 3.0PR19Q1.2
2019-07-09 18:19shuehnerTarget Version3.0PR19Q1.2 => 3.0PR19Q1.3
2019-07-17 11:26hgbotCheckin
2019-07-17 11:26hgbotNote Added: 0113470
2019-07-17 11:26hgbotStatusscheduled => resolved
2019-07-17 11:26hgbotResolutionopen => fixed
2019-07-17 11:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q1.3/rev/0d3ff7b92273929ffbbe8b331b8f3f432d43379c [^]
2019-07-17 11:27dmiguelezReview Assigned To => dmiguelez
2019-07-17 11:27dmiguelezNote Added: 0113474
2019-07-17 11:27dmiguelezStatusresolved => closed
2019-07-17 11:27dmiguelezFixed in Version => 3.0PR19Q1.3

Notes
(0113470)
hgbot   
2019-07-17 11:26   
Repository: erp/backports/3.0PR19Q1.3
Changeset: 0d3ff7b92273929ffbbe8b331b8f3f432d43379c
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Jul 15 18:15:38 2019 +0530
URL: http://code.openbravo.com/erp/backports/3.0PR19Q1.3/rev/0d3ff7b92273929ffbbe8b331b8f3f432d43379c [^]

Fixes Issue 41256: ReportProjectProfitabilityJR.noConversionToHours
is not using bind-params

Applied bind-params to organization ids in noConversionToHours
method. Organization ids are obtained from OrganizationStructureProvider

---
M src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.java
---
(0113474)
dmiguelez   
2019-07-17 11:27   
Code Review + Testing Ok