Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0041237 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 09. Financial management | minor | have not tried | 2019-07-02 15:54 | 2019-08-22 14:45 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | collazoandy4 | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR19Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 5c4436714166 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR19Q4 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | Sandrahuguet | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0041237: FIN_BankstatementImport is not using bind-params | |||||||
| Description | The following functions are not using bind-params: - matchPreviousBSL - findBPByName - matchBusinessPartnerByNameTokens(String, Organization) Example wrong code: whereClause.append(" and b." + BusinessPartner.PROPERTY_ORGANIZATION + ".id in ("); whereClause.append(Utility.getInStrSet( new OrganizationStructureProvider().getNaturalTree(organization.getId())) + ") "); When fixing please apply new HQL-style to all the file. | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0113579) collazoandy4 (reporter) 2019-07-22 23:59 |
Test Plan Install the OFX Bank Statement Format module and apply the dataset Go to Financial Account and select Cuenta de Banco record Clic on Import Statement and select a valid OFX file and check the process ends without errors |
|
(0113879) hgbot (developer) 2019-08-07 14:07 |
Repository: erp/devel/pi Changeset: 5c4436714166541ed74368cd3d1b6decb5ec5ccb Author: Armaignac <collazoandy4 <at> gmail.com> Date: Mon Jul 22 15:00:30 2019 -0400 URL: http://code.openbravo.com/erp/devel/pi/rev/5c4436714166541ed74368cd3d1b6decb5ec5ccb [^] Fixes issue 41237: FIN_BankstatementImport is not using bind-params Added bind-params in matchPreviousBSL, findBPByName and matchBusinessPartnerByNameTokens(String, Organization) methods --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java --- |
|
(0113881) Sandrahuguet (developer) 2019-08-07 14:10 |
code review + testing ok |
|
(0114216) hudsonbot (developer) 2019-08-22 14:45 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-07-02 15:54 | shuehner | New Issue | |
| 2019-07-02 15:54 | shuehner | Assigned To | => Triage Finance |
| 2019-07-02 15:54 | shuehner | Modules | => Core |
| 2019-07-02 15:54 | shuehner | Triggers an Emergency Pack | => No |
| 2019-07-02 15:54 | shuehner | Relationship added | blocks 0038136 |
| 2019-07-04 12:15 | shuehner | Target Version | => 3.0PR19Q4 |
| 2019-07-22 16:04 | collazoandy4 | Assigned To | Triage Finance => collazoandy4 |
| 2019-07-22 16:04 | collazoandy4 | Status | new => scheduled |
| 2019-07-22 23:59 | collazoandy4 | Note Added: 0113579 | |
| 2019-08-07 12:50 | Sandrahuguet | Relationship added | related to 0041417 |
| 2019-08-07 14:07 | hgbot | Checkin | |
| 2019-08-07 14:07 | hgbot | Note Added: 0113879 | |
| 2019-08-07 14:07 | hgbot | Status | scheduled => resolved |
| 2019-08-07 14:07 | hgbot | Resolution | open => fixed |
| 2019-08-07 14:07 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/5c4436714166541ed74368cd3d1b6decb5ec5ccb [^] |
| 2019-08-07 14:10 | Sandrahuguet | Review Assigned To | => Sandrahuguet |
| 2019-08-07 14:10 | Sandrahuguet | Note Added: 0113881 | |
| 2019-08-07 14:10 | Sandrahuguet | Status | resolved => closed |
| 2019-08-07 14:10 | Sandrahuguet | Fixed in Version | => 3.0PR19Q4 |
| 2019-08-22 14:45 | hudsonbot | Checkin | |
| 2019-08-22 14:45 | hudsonbot | Note Added: 0114216 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |