Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041237Openbravo ERP09. Financial managementpublic2019-07-02 15:542019-08-22 14:45
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4Fixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041237: FIN_BankstatementImport is not using bind-params
DescriptionThe following functions are not using bind-params:
- matchPreviousBSL
- findBPByName
- matchBusinessPartnerByNameTokens(String, Organization)


Example wrong code:
      whereClause.append(" and b." + BusinessPartner.PROPERTY_ORGANIZATION + ".id in (");
      whereClause.append(Utility.getInStrSet(
          new OrganizationStructureProvider().getNaturalTree(organization.getId())) + ") ");

When fixing please apply new HQL-style to all the file.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041417 closed collazoandy4 Apply HQL style guide to FIN_BankstatementImport 
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-02 15:54shuehnerNew Issue
2019-07-02 15:54shuehnerAssigned To => Triage Finance
2019-07-02 15:54shuehnerModules => Core
2019-07-02 15:54shuehnerTriggers an Emergency Pack => No
2019-07-02 15:54shuehnerRelationship addedblocks 0038136
2019-07-04 12:15shuehnerTarget Version => 3.0PR19Q4
2019-07-22 16:04collazoandy4Assigned ToTriage Finance => collazoandy4
2019-07-22 16:04collazoandy4Statusnew => scheduled
2019-07-22 23:59collazoandy4Note Added: 0113579
2019-08-07 12:50SandrahuguetRelationship addedrelated to 0041417
2019-08-07 14:07hgbotCheckin
2019-08-07 14:07hgbotNote Added: 0113879
2019-08-07 14:07hgbotStatusscheduled => resolved
2019-08-07 14:07hgbotResolutionopen => fixed
2019-08-07 14:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5c4436714166541ed74368cd3d1b6decb5ec5ccb [^]
2019-08-07 14:10SandrahuguetReview Assigned To => Sandrahuguet
2019-08-07 14:10SandrahuguetNote Added: 0113881
2019-08-07 14:10SandrahuguetStatusresolved => closed
2019-08-07 14:10SandrahuguetFixed in Version => 3.0PR19Q4
2019-08-22 14:45hudsonbotCheckin
2019-08-22 14:45hudsonbotNote Added: 0114216

Notes
(0113579)
collazoandy4   
2019-07-22 23:59   
Test Plan
 Install the OFX Bank Statement Format module and apply the dataset
 Go to Financial Account and select Cuenta de Banco record
 Clic on Import Statement and select a valid OFX file and check the process ends without errors
(0113879)
hgbot   
2019-08-07 14:07   
Repository: erp/devel/pi
Changeset: 5c4436714166541ed74368cd3d1b6decb5ec5ccb
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Mon Jul 22 15:00:30 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/5c4436714166541ed74368cd3d1b6decb5ec5ccb [^]

Fixes issue 41237: FIN_BankstatementImport is not using bind-params

Added bind-params in matchPreviousBSL, findBPByName and
matchBusinessPartnerByNameTokens(String, Organization) methods

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
---
(0113881)
Sandrahuguet   
2019-08-07 14:10   
code review + testing ok
(0114216)
hudsonbot   
2019-08-22 14:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test