Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041231
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminorhave not tried2019-07-02 15:412019-08-22 14:44
ReportershuehnerView Statuspublic 
Assigned Tocollazoandy4 
PrioritynormalResolutionfixedFixed in Version3.0PR19Q4
StatusclosedFix in branchFixed in SCM revisionc0b264209dbb
ProjectionnoneETAnoneTarget Version3.0PR19Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041231: Reconciliation is not using bind-params

DescriptionThis code is not using bind-params:
  private String linesInNotAvailablePeriod(String reconciliationId) {

    hql.append(" where rl.reconciliation.id = '").append(reconciliationId).append("' ");
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks design defect 0038136 acknowledgedTriage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 

-  Notes
(0113488)
collazoandy4 (reporter)
2019-07-18 06:38

 Test Plan
  Create a new Sales Invoice with 'Al contado' payment method and complete it and add a payment to it
  Go to Financial Account window and select Caja record
    Create a new Funds Transfer with the payment amount
    Select the transaccion created by the invoice and clic on Reconcile
      Select the two records and clic on Reconcilie
    Check the process ends with out errors
(0113526)
hgbot (developer)
2019-07-18 16:25

 Repository: erp/devel/pi
Changeset: c0b264209dbb682f3924893e64f583c3910bde2a
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Jul 18 16:11:43 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c0b264209dbb682f3924893e64f583c3910bde2a [^]

Fixes issue 41231: Reconciliation is not using bind-params

Applied bind params in linesInNotAvailablePeriod method

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/Reconciliation.java
---
(0113528)
dmiguelez (developer)
2019-07-18 16:26

 Code Review + Testing Ok
(0114160)
hudsonbot (developer)
2019-08-22 14:44

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2019-07-02 15:41 shuehner New Issue
2019-07-02 15:41 shuehner Assigned To => Triage Finance
2019-07-02 15:41 shuehner Modules => Core
2019-07-02 15:41 shuehner Triggers an Emergency Pack => No
2019-07-02 15:41 shuehner Relationship added blocks 0038136
2019-07-04 12:14 shuehner Target Version => 3.0PR19Q4
2019-07-17 06:41 collazoandy4 Assigned To Triage Finance => collazoandy4
2019-07-17 06:42 collazoandy4 Status new => scheduled
2019-07-18 06:38 collazoandy4 Note Added: 0113488
2019-07-18 16:25 hgbot Checkin
2019-07-18 16:25 hgbot Note Added: 0113526
2019-07-18 16:25 hgbot Status scheduled => resolved
2019-07-18 16:25 hgbot Resolution open => fixed
2019-07-18 16:25 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c0b264209dbb682f3924893e64f583c3910bde2a [^]
2019-07-18 16:26 dmiguelez Review Assigned To => dmiguelez
2019-07-18 16:26 dmiguelez Note Added: 0113528
2019-07-18 16:26 dmiguelez Status resolved => closed
2019-07-18 16:26 dmiguelez Fixed in Version => 3.0PR19Q4
2019-08-22 14:44 hudsonbot Checkin
2019-08-22 14:44 hudsonbot Note Added: 0114160

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker