Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041231Openbravo ERP09. Financial managementpublic2019-07-02 15:412019-08-22 14:44
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4Fixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041231: Reconciliation is not using bind-params
DescriptionThis code is not using bind-params:
  private String linesInNotAvailablePeriod(String reconciliationId) {

    hql.append(" where rl.reconciliation.id = '").append(reconciliationId).append("' ");
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-02 15:41shuehnerNew Issue
2019-07-02 15:41shuehnerAssigned To => Triage Finance
2019-07-02 15:41shuehnerModules => Core
2019-07-02 15:41shuehnerTriggers an Emergency Pack => No
2019-07-02 15:41shuehnerRelationship addedblocks 0038136
2019-07-04 12:14shuehnerTarget Version => 3.0PR19Q4
2019-07-17 06:41collazoandy4Assigned ToTriage Finance => collazoandy4
2019-07-17 06:42collazoandy4Statusnew => scheduled
2019-07-18 06:38collazoandy4Note Added: 0113488
2019-07-18 16:25hgbotCheckin
2019-07-18 16:25hgbotNote Added: 0113526
2019-07-18 16:25hgbotStatusscheduled => resolved
2019-07-18 16:25hgbotResolutionopen => fixed
2019-07-18 16:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c0b264209dbb682f3924893e64f583c3910bde2a [^]
2019-07-18 16:26dmiguelezReview Assigned To => dmiguelez
2019-07-18 16:26dmiguelezNote Added: 0113528
2019-07-18 16:26dmiguelezStatusresolved => closed
2019-07-18 16:26dmiguelezFixed in Version => 3.0PR19Q4
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114160

Notes
(0113488)
collazoandy4   
2019-07-18 06:38   
Test Plan
  Create a new Sales Invoice with 'Al contado' payment method and complete it and add a payment to it
  Go to Financial Account window and select Caja record
    Create a new Funds Transfer with the payment amount
    Select the transaccion created by the invoice and clic on Reconcile
      Select the two records and clic on Reconcilie
    Check the process ends with out errors
(0113526)
hgbot   
2019-07-18 16:25   
Repository: erp/devel/pi
Changeset: c0b264209dbb682f3924893e64f583c3910bde2a
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Jul 18 16:11:43 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c0b264209dbb682f3924893e64f583c3910bde2a [^]

Fixes issue 41231: Reconciliation is not using bind-params

Applied bind params in linesInNotAvailablePeriod method

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/Reconciliation.java
---
(0113528)
dmiguelez   
2019-07-18 16:26   
Code Review + Testing Ok
(0114160)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test