Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0041109

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

design defect

[Openbravo ERP] A. Platform

minor

have not tried

2019-06-17 17:03

2022-02-01 08:07

Reporter

caristu

View Status

public

Assigned To

Triage Platform Base

Priority

normal

Resolution

open

Fixed in Version

Status

new

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

OBNetwork customer

No

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0041109: Improvements in ImportEntryPreProcessor/ImportEntryPostProcessor

Description

There are some improvements related with ImportEntryPreProcessor and ImportEntryPostProcessor classes that can be applied:

- ImportEntryPreProcessor should be defined as an interface instead of an abstract class.
- ImportEntryPostProcessor should be defined as an interface instead of an abstract class.
- Currently ImportEntryPostProcessor instances are not being injected in any component of the ImportEntryManager infrastructure (This was removed here[1]). Instead, they are being injected in classes extending ImportEntryProcessRunnable. See [2].
- Both component are not behaving in the same way: ImportEntryPreProcessor instances are executed for all type of data[4]. This is not the case of ImportEntryPostProcessor here[2].

As an additional comment, note that ImportEntryPostProcessor instances are also being injected in an action handler used when importing data from the [Errors While Importing POS Data] window" module[3].

[1] https://code.openbravo.com/erp/devel/pi/rev/302d949e828a772c0778017126f54b8563a9d6ec [^]
[2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/process/MobileImportEntryProcessorRunnable.java#l38 [^]
[3] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/SaveDataActionHandler.java#l53 [^]
[4]
https://code.openbravo.com/erp/devel/pi/file/tip/src/org/openbravo/service/importprocess/ImportEntryBuilder.java#l233 [^]

Steps To Reproduce

In description

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	feature request	0031564	3.0PR16Q1	closed	gorkaion	Openbravo ERP	Add ability to inject logic to an import entry processor when the process has finished and committed
related to	defect	0036037		closed	migueldejuana	Retail Modules	PostImportEntry hook is getting executed even if the record goes to Errors While Importing window
related to	defect	0033104		closed	mario_castello	Retail Modules	Import Entry Post Processor does not get called if the entity goes to errors while importing
related to	defect	0049438		closed	ranjith_qualiantech_com	Retail Modules	PostImportEntry is not being executed in some escenarios with multiple documents

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2019-06-17 17:03	caristu	New Issue
2019-06-17 17:03	caristu	Assigned To	=> platform
2019-06-17 17:03	caristu	OBNetwork customer	=> No
2019-06-17 17:03	caristu	Modules	=> Core
2019-06-17 17:03	caristu	Triggers an Emergency Pack	=> No
2019-06-17 17:04	caristu	Relationship added	related to 0031564
2019-06-17 17:10	caristu	Relationship added	related to 0036037
2019-06-17 17:11	caristu	Description Updated	View Revisions
2019-06-17 17:12	caristu	Description Updated	View Revisions
2019-06-17 17:15	caristu	Relationship added	related to 0033104
2019-06-17 17:18	caristu	Description Updated	View Revisions
2019-06-17 17:19	caristu	Description Updated	View Revisions
2019-06-17 18:04	caristu	Description Updated	View Revisions
2019-06-17 18:08	caristu	Description Updated	View Revisions
2019-06-17 18:09	caristu	Description Updated	View Revisions
2019-06-17 18:09	caristu	Type	defect => design defect
2022-02-01 08:07	alostale	Assigned To	platform => Triage Platform Base
2022-05-30 15:05	gorkaion	Relationship added	related to 0049438

Copyright © 2000 - 2009 MantisBT Group