Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041109Openbravo ERPA. Platformpublic2019-06-17 17:032022-02-01 08:07
Reportercaristu 
Assigned ToTriage Platform Base 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusnewResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041109: Improvements in ImportEntryPreProcessor/ImportEntryPostProcessor
DescriptionThere are some improvements related with ImportEntryPreProcessor and ImportEntryPostProcessor classes that can be applied:

- ImportEntryPreProcessor should be defined as an interface instead of an abstract class.
- ImportEntryPostProcessor should be defined as an interface instead of an abstract class.
- Currently ImportEntryPostProcessor instances are not being injected in any component of the ImportEntryManager infrastructure (This was removed here[1]). Instead, they are being injected in classes extending ImportEntryProcessRunnable. See [2].
- Both component are not behaving in the same way: ImportEntryPreProcessor instances are executed for all type of data[4]. This is not the case of ImportEntryPostProcessor here[2].

As an additional comment, note that ImportEntryPostProcessor instances are also being injected in an action handler used when importing data from the [Errors While Importing POS Data] window" module[3].

[1] https://code.openbravo.com/erp/devel/pi/rev/302d949e828a772c0778017126f54b8563a9d6ec [^]
[2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/process/MobileImportEntryProcessorRunnable.java#l38 [^]
[3] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/SaveDataActionHandler.java#l53 [^]
[4]
https://code.openbravo.com/erp/devel/pi/file/tip/src/org/openbravo/service/importprocess/ImportEntryBuilder.java#l233 [^]
Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 00315643.0PR16Q1 closed gorkaion Openbravo ERP Add ability to inject logic to an import entry processor when the process has finished and committed 
related to defect 0036037 closed migueldejuana Retail Modules PostImportEntry hook is getting executed even if the record goes to Errors While Importing window 
related to defect 0033104 closed mario_castello Retail Modules Import Entry Post Processor does not get called if the entity goes to errors while importing 
related to defect 0049438 closed ranjith_qualiantech_com Retail Modules PostImportEntry is not being executed in some escenarios with multiple documents 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-06-17 17:03caristuNew Issue
2019-06-17 17:03caristuAssigned To => platform
2019-06-17 17:03caristuModules => Core
2019-06-17 17:03caristuTriggers an Emergency Pack => No
2019-06-17 17:04caristuRelationship addedrelated to 0031564
2019-06-17 17:10caristuRelationship addedrelated to 0036037
2019-06-17 17:11caristuDescription Updatedbug_revision_view_page.php?rev_id=18946#r18946
2019-06-17 17:12caristuDescription Updatedbug_revision_view_page.php?rev_id=18947#r18947
2019-06-17 17:15caristuRelationship addedrelated to 0033104
2019-06-17 17:18caristuDescription Updatedbug_revision_view_page.php?rev_id=18948#r18948
2019-06-17 17:19caristuDescription Updatedbug_revision_view_page.php?rev_id=18949#r18949
2019-06-17 18:04caristuDescription Updatedbug_revision_view_page.php?rev_id=18950#r18950
2019-06-17 18:08caristuDescription Updatedbug_revision_view_page.php?rev_id=18951#r18951
2019-06-17 18:09caristuDescription Updatedbug_revision_view_page.php?rev_id=18952#r18952
2019-06-17 18:09caristuTypedefect => design defect
2022-02-01 08:07alostaleAssigned Toplatform => Triage Platform Base
2022-05-30 15:05gorkaionRelationship addedrelated to 0049438

There are no notes attached to this issue.