Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0040920
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminorhave not tried2019-05-20 15:112019-05-30 10:36
ReporterAtulOpenbravoView Statuspublic 
Assigned ToAtulOpenbravo 
PrioritynormalResolutionfixedFixed in Version3.0PR19Q3
StatusclosedFix in branchFixed in SCM revision5a6a471f804f
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tovmromanos
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040920: API Change:Remove Transaction Old 2 Tab, its fields, Delete & Modify Transaction

DescriptionRemove Transaction Old 2 Tab and its fields from Financial Account window.
Remove DeleteTransaction and FIN_ModifyTransaction button process, its Model Object & its Model Object Mapping. Process access in F&B International Group and QA Testing sample data.

This tab id has references as below:
org.openbravo.alerts.accounting30 (this module is tried to install using Enterprise Module Management in the ADMc_SetupClientAndOrganization test when running try-initial-** job)
- NOT BALANCED FINANCIAL ACCOUNT TRANSACTION.
- SUSPENSE ERROR IN FINANCIAL ACCOUNT TRANSACTION.
- SUSPENSE BALANCING IN FINANCIAL ACCOUNT TRANSACTION.
org.openbravo.advpaymentmngt.alerts
- Transaction disabled for accounting.

Modulescript
- Used in CreateAccountingConfiguration_data.xsql method deleteTableAccess,
to delete records having created date prior to date creation of Tab - Transaction Old 2

BuildValidation
- Used in DuplicateDocExchangeRate.java as static variable TRANSACTION_HEADER_TAB
to set Duplicate Exchange Rate alerts for Tab - Transaction Old 2

All of the id references can be safely replaced by tab id of active Tab i.e Financial Account - Transaction tab.

Remove columns EM_APRM_Delete & EM_APRM_Modify from DB table & View, its application dictionary references i.e AD_COLUMN, AD_FIELD & AD_ELEMENT
Remove unused files PaymentGLItemGrid.srpt & PaymentGLItemGrid.xml
Remove text interfaces associated with PaymentGLItemGrid.srptText Interfaces.

The tab is inactive and not used any more. Removing DeleteTransaction.java, FIN_TransactionModify.java has low risk as sample data references can be managed safely.

AD_Process_Access has references to the DeleteTransaction & FIN_TransactionModify process with in Sample Data for F&B International Group, QA Testing in Core, The White Valley Group in Retail Sample Data module, AWO QA in AWO Sample Data Module.

Removing below methods that were only used in Transactions.java also has low risk as they are not used in the any other classes.
* TransactionsDao - getTransactionsToReconciled
* TransactionsDao - post
* Getter and Setter methods for EM_APRM_DELETE & EM_APRM_Modify columns of table FIN_FINACC_TRANSACTION and view APRM_FINACC_TRANSACTION_V
Steps To Reproduce-
TagsApproved
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by feature request 00357883.0PR19Q3 closedAtulOpenbravo Remove obsolete, disabled & non-working class: org.openbravo.advpaymentmngt.ad_forms.Transactions 

-  Notes
(0112130)
hgbot (developer)
2019-05-24 16:50

 Repository: erp/devel/api-checks
Changeset: 5a6a471f804f02409307f9f392f847e40839bbc3
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri May 24 20:18:54 2019 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/5a6a471f804f02409307f9f392f847e40839bbc3 [^]

Fixes Issue 40920: API Change:Remove Transaction Old 2 Tab,
its fields, Delete & Modify Transaction

** Remove Tab APRM Transaction Old 2 Tab & its fields from Financial
Account window, remove Auxiliar Inputs defined for the tab.
** Remove column for delete and modify button in
FIN_FINACC_TRANSACTION table, AD_COLUMN, AD_FIELD & AD_ELEMENT
** Remove columns from APRM_FINACC_TRANSACTION_V view, AD_COLUMN, AD_FIELD
and AD_ELEMENT
** Remove DeleteTransaction & FIN_TransactionModify process, its parameters,
class and its model object.
** Remove text interfaces for PaymentGLItemGrid.srpt

---
M model/modules/org.openbravo.advpaymentmngt/src-db/database/model/modifiedTables/FIN_FINACC_TRANSACTION.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/model/views/APRM_FINACC_TRANSACTION_V.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_AUXILIARINPUT.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_PROCESS.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_PROCESS_PARA.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TAB.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0112131)
hgbot (developer)
2019-05-24 16:50

 Repository: erp/devel/api-checks
Changeset: 0824f6e785eee272193938f2c6f712c489b525a2
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri May 24 20:19:32 2019 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/0824f6e785eee272193938f2c6f712c489b525a2 [^]

Related To Issue 40920: API Change - Remove Delete & Modify Transaction,
fields properties, getter & setter methods, methods of TransactionDao

** Remove java classes DeleteTransaction & FIN_TransactionModify
** Remove fields PROPERTY_DELETEBTN & PROPERTY_MODIFY for
APRM_FinaccTransactionV
** Remove fields PROPERTY_APRMDELETE & PROPERTY_APRMMODIFY for
FIN_FinaccTransaction
** Remove getter setter methods for the field of columns EM_APRM_Delete &
EM_APRM_MODIFY from class APRM_FinaccTransactionV & FIN_FinaccTransaction
** Remove methods post and getTransactionsToReconciled of TransactionsDao
class

---
M java/reference/java.japi.gz
---
(0112262)
vmromanos (manager)
2019-05-30 10:36

 CI passed successfully

- Issue History
Date Modified Username Field Change
2019-05-20 15:11 AtulOpenbravo New Issue
2019-05-20 15:11 AtulOpenbravo Assigned To => dmitry_mezentsev
2019-05-20 15:11 AtulOpenbravo Modules => Core
2019-05-20 15:11 AtulOpenbravo Triggers an Emergency Pack => No
2019-05-20 15:11 AtulOpenbravo Issue generated from 0040561
2019-05-20 15:14 AtulOpenbravo Description Updated View Revisions
2019-05-22 09:44 dmitry_mezentsev Tag Attached: Approved
2019-05-22 09:44 dmitry_mezentsev Assigned To dmitry_mezentsev => AtulOpenbravo
2019-05-22 11:05 AtulOpenbravo Status new => scheduled
2019-05-24 16:50 hgbot Checkin
2019-05-24 16:50 hgbot Note Added: 0112130
2019-05-24 16:50 hgbot Status scheduled => resolved
2019-05-24 16:50 hgbot Resolution open => fixed
2019-05-24 16:50 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/5a6a471f804f02409307f9f392f847e40839bbc3 [^]
2019-05-24 16:50 hgbot Checkin
2019-05-24 16:50 hgbot Note Added: 0112131
2019-05-30 10:35 vmromanos Relationship added caused by 0035788
2019-05-30 10:36 vmromanos Review Assigned To => vmromanos
2019-05-30 10:36 vmromanos Note Added: 0112262
2019-05-30 10:36 vmromanos Status resolved => closed
2019-05-30 10:36 vmromanos Fixed in Version => 3.0PR19Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker