Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040920Openbravo ERP09. Financial managementpublic2019-05-20 15:112019-05-30 10:36
ReporterAtulOpenbravo 
Assigned ToAtulOpenbravo 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040920: API Change:Remove Transaction Old 2 Tab, its fields, Delete & Modify Transaction
DescriptionRemove Transaction Old 2 Tab and its fields from Financial Account window.
Remove DeleteTransaction and FIN_ModifyTransaction button process, its Model Object & its Model Object Mapping. Process access in F&B International Group and QA Testing sample data.

This tab id has references as below:
org.openbravo.alerts.accounting30 (this module is tried to install using Enterprise Module Management in the ADMc_SetupClientAndOrganization test when running try-initial-** job)
- NOT BALANCED FINANCIAL ACCOUNT TRANSACTION.
- SUSPENSE ERROR IN FINANCIAL ACCOUNT TRANSACTION.
- SUSPENSE BALANCING IN FINANCIAL ACCOUNT TRANSACTION.
org.openbravo.advpaymentmngt.alerts
- Transaction disabled for accounting.

Modulescript
- Used in CreateAccountingConfiguration_data.xsql method deleteTableAccess,
to delete records having created date prior to date creation of Tab - Transaction Old 2

BuildValidation
- Used in DuplicateDocExchangeRate.java as static variable TRANSACTION_HEADER_TAB
to set Duplicate Exchange Rate alerts for Tab - Transaction Old 2

All of the id references can be safely replaced by tab id of active Tab i.e Financial Account - Transaction tab.

Remove columns EM_APRM_Delete & EM_APRM_Modify from DB table & View, its application dictionary references i.e AD_COLUMN, AD_FIELD & AD_ELEMENT
Remove unused files PaymentGLItemGrid.srpt & PaymentGLItemGrid.xml
Remove text interfaces associated with PaymentGLItemGrid.srptText Interfaces.

The tab is inactive and not used any more. Removing DeleteTransaction.java, FIN_TransactionModify.java has low risk as sample data references can be managed safely.

AD_Process_Access has references to the DeleteTransaction & FIN_TransactionModify process with in Sample Data for F&B International Group, QA Testing in Core, The White Valley Group in Retail Sample Data module, AWO QA in AWO Sample Data Module.

Removing below methods that were only used in Transactions.java also has low risk as they are not used in the any other classes.
* TransactionsDao - getTransactionsToReconciled
* TransactionsDao - post
* Getter and Setter methods for EM_APRM_DELETE & EM_APRM_Modify columns of table FIN_FINACC_TRANSACTION and view APRM_FINACC_TRANSACTION_V
Steps To Reproduce-
Proposed Solution
Additional Information
TagsApproved
Relationships
caused by feature request 00357883.0PR19Q3 closed AtulOpenbravo Remove obsolete, disabled & non-working class: org.openbravo.advpaymentmngt.ad_forms.Transactions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-05-20 15:11AtulOpenbravoNew Issue
2019-05-20 15:11AtulOpenbravoAssigned To => dmitry_mezentsev
2019-05-20 15:11AtulOpenbravoModules => Core
2019-05-20 15:11AtulOpenbravoTriggers an Emergency Pack => No
2019-05-20 15:11AtulOpenbravoIssue generated from0040561
2019-05-20 15:14AtulOpenbravoDescription Updatedbug_revision_view_page.php?rev_id=18796#r18796
2019-05-22 09:44dmitry_mezentsevTag Attached: Approved
2019-05-22 09:44dmitry_mezentsevAssigned Todmitry_mezentsev => AtulOpenbravo
2019-05-22 11:05AtulOpenbravoStatusnew => scheduled
2019-05-24 16:50hgbotCheckin
2019-05-24 16:50hgbotNote Added: 0112130
2019-05-24 16:50hgbotStatusscheduled => resolved
2019-05-24 16:50hgbotResolutionopen => fixed
2019-05-24 16:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/5a6a471f804f02409307f9f392f847e40839bbc3 [^]
2019-05-24 16:50hgbotCheckin
2019-05-24 16:50hgbotNote Added: 0112131
2019-05-30 10:35vmromanosRelationship addedcaused by 0035788
2019-05-30 10:36vmromanosReview Assigned To => vmromanos
2019-05-30 10:36vmromanosNote Added: 0112262
2019-05-30 10:36vmromanosStatusresolved => closed
2019-05-30 10:36vmromanosFixed in Version => 3.0PR19Q3

Notes
(0112130)
hgbot   
2019-05-24 16:50   
Repository: erp/devel/api-checks
Changeset: 5a6a471f804f02409307f9f392f847e40839bbc3
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri May 24 20:18:54 2019 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/5a6a471f804f02409307f9f392f847e40839bbc3 [^]

Fixes Issue 40920: API Change:Remove Transaction Old 2 Tab,
its fields, Delete & Modify Transaction

** Remove Tab APRM Transaction Old 2 Tab & its fields from Financial
Account window, remove Auxiliar Inputs defined for the tab.
** Remove column for delete and modify button in
FIN_FINACC_TRANSACTION table, AD_COLUMN, AD_FIELD & AD_ELEMENT
** Remove columns from APRM_FINACC_TRANSACTION_V view, AD_COLUMN, AD_FIELD
and AD_ELEMENT
** Remove DeleteTransaction & FIN_TransactionModify process, its parameters,
class and its model object.
** Remove text interfaces for PaymentGLItemGrid.srpt

---
M model/modules/org.openbravo.advpaymentmngt/src-db/database/model/modifiedTables/FIN_FINACC_TRANSACTION.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/model/views/APRM_FINACC_TRANSACTION_V.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_AUXILIARINPUT.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_PROCESS.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_PROCESS_PARA.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TAB.xml
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0112131)
hgbot   
2019-05-24 16:50   
Repository: erp/devel/api-checks
Changeset: 0824f6e785eee272193938f2c6f712c489b525a2
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri May 24 20:19:32 2019 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/0824f6e785eee272193938f2c6f712c489b525a2 [^]

Related To Issue 40920: API Change - Remove Delete & Modify Transaction,
fields properties, getter & setter methods, methods of TransactionDao

** Remove java classes DeleteTransaction & FIN_TransactionModify
** Remove fields PROPERTY_DELETEBTN & PROPERTY_MODIFY for
APRM_FinaccTransactionV
** Remove fields PROPERTY_APRMDELETE & PROPERTY_APRMMODIFY for
FIN_FinaccTransaction
** Remove getter setter methods for the field of columns EM_APRM_Delete &
EM_APRM_MODIFY from class APRM_FinaccTransactionV & FIN_FinaccTransaction
** Remove methods post and getTransactionsToReconciled of TransactionsDao
class

---
M java/reference/java.japi.gz
---
(0112262)
vmromanos   
2019-05-30 10:36   
CI passed successfully