Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0040820 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Advanced Warehouse Operations | major | always | 2019-05-09 12:58 | 2019-05-24 11:29 | |||
| Reporter | dmiguelez | View Status | public | |||||
| Assigned To | nonofrancisco | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | Sandrahuguet | |||||||
| Support ticket | ||||||||
| OBNetwork customer | No | |||||||
| Regression introduced in release | ||||||||
| Summary | 0040820: Performance problems when auto-confirming hundreds of Box Tasks in Functional Area | |||||||
| Description | Performance problems when auto-confirming hundreds of Box Tasks in Functional Area | |||||||
| Steps To Reproduce | Log in as AWO QA Admin Go to Warehouse Definition window and select West Coast Warehouse Go to Internal Routing Area Tab and set all areas as Functional = 'Y' Apply the attached patch in AWO module and launch the new AWOzzri_HighVolumeRI test case. For 800 Products it takes 1000 seconds | |||||||
| Proposed Solution | This diff is not final, just a guide to the possible solution: diff --git a/src/org/openbravo/warehouse/advancedwarehouseoperations/occupancy/OccupancyCalculator.java b/src/org/openbravo/warehouse/advancedwarehouseoperations/occupancy/OccupancyCalculator.java --- a/src/org/openbravo/warehouse/advancedwarehouseoperations/occupancy/OccupancyCalculator.java +++ b/src/org/openbravo/warehouse/advancedwarehouseoperations/occupancy/OccupancyCalculator.java @@ -70,9 +70,11 @@ // organization final Locator locator = getLocator(); OBDal.getInstance().refresh(locator); // To get last object in DB after triggers execution + if (locator.getOBAWOLocatorGroup().getInternalRoutingArea().isFunctional()) { + return success; + } AWOLoggerForProcessUtil.logEmptyLine(log); - AWOLoggerForProcessUtil.logInfo(log, - AWOLoggerForProcessUtil.IDENTATION_LEVEL_GENERAL_PROCESS, + AWOLoggerForProcessUtil.logInfo(log, AWOLoggerForProcessUtil.IDENTATION_LEVEL_GENERAL_PROCESS, "Started calculation of occupancy for storage bin '%s'", locator.getIdentifier()); if (!OccupancyUtils.isLocatorConfiguredForOccupancy(locatorId)) { | |||||||
| Tags | Performance | |||||||
| Attached Files | ||||||||
Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
Notes |
|
|
(0112119) hgbot (developer) 2019-05-24 11:28 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: ec316821859325b1c524f0a5d5d7ab30644c1585 Author: Nono Carballo <nonofce <at> gmail.com> Date: Tue May 21 17:06:51 2019 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/ec316821859325b1c524f0a5d5d7ab30644c1585 [^] Fix for issue 40820: Avoid logs to improve performance Avoids log creation in flows where it is not necessary. --- M src/org/openbravo/warehouse/advancedwarehouseoperations/occupancy/OccupancyCalculator.java M src/org/openbravo/warehouse/advancedwarehouseoperations/occupancy/OccupancyUtils.java --- |
|
(0112120) Sandrahuguet (viewer) 2019-05-24 11:29 |
code review + testing ok |
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-05-09 12:58 | dmiguelez | New Issue | |
| 2019-05-09 12:58 | dmiguelez | Assigned To | => Triage Finance |
| 2019-05-09 12:58 | dmiguelez | OBNetwork customer | => No |
| 2019-05-09 13:36 | Sandrahuguet | Assigned To | Triage Finance => nonofrancisco |
| 2019-05-15 10:44 | dmitry_mezentsev | Relationship added | related to 0040759 |
| 2019-05-16 23:51 | nonofrancisco | Status | new => scheduled |
| 2019-05-21 15:46 | Sandrahuguet | Tag Attached: Performance | |
| 2019-05-24 11:28 | hgbot | Checkin | |
| 2019-05-24 11:28 | hgbot | Note Added: 0112119 | |
| 2019-05-24 11:28 | Sandrahuguet | Status | scheduled => resolved |
| 2019-05-24 11:28 | Sandrahuguet | Resolution | open => fixed |
| 2019-05-24 11:29 | Sandrahuguet | Review Assigned To | => Sandrahuguet |
| 2019-05-24 11:29 | Sandrahuguet | Note Added: 0112120 | |
| 2019-05-24 11:29 | Sandrahuguet | Status | resolved => closed |
| 2022-09-06 17:18 | caristu | Category | Advance Warehouse Operations => Advanced Warehouse Operations |
| Copyright © 2000 - 2009 MantisBT Group |