Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040820ModulesAdvanced Warehouse Operationspublic2019-05-09 12:582019-05-24 11:29
Reporterdmiguelez 
Assigned Tononofrancisco 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Support ticket
OBNetwork customer
Regression introduced in release
Summary0040820: Performance problems when auto-confirming hundreds of Box Tasks in Functional Area
DescriptionPerformance problems when auto-confirming hundreds of Box Tasks in Functional Area
Steps To ReproduceLog in as AWO QA Admin

Go to Warehouse Definition window and select West Coast Warehouse
Go to Internal Routing Area Tab and set all areas as Functional = 'Y'

Apply the attached patch in AWO module and launch the new AWOzzri_HighVolumeRI test case. For 800 Products it takes 1000 seconds
Proposed SolutionThis diff is not final, just a guide to the possible solution:

diff --git a/src/org/openbravo/warehouse/advancedwarehouseoperations/occupancy/OccupancyCalculator.java b/src/org/openbravo/warehouse/advancedwarehouseoperations/occupancy/OccupancyCalculator.java
--- a/src/org/openbravo/warehouse/advancedwarehouseoperations/occupancy/OccupancyCalculator.java
+++ b/src/org/openbravo/warehouse/advancedwarehouseoperations/occupancy/OccupancyCalculator.java
@@ -70,9 +70,11 @@
       // organization
       final Locator locator = getLocator();
       OBDal.getInstance().refresh(locator); // To get last object in DB after triggers execution
+ if (locator.getOBAWOLocatorGroup().getInternalRoutingArea().isFunctional()) {
+ return success;
+ }
       AWOLoggerForProcessUtil.logEmptyLine(log);
- AWOLoggerForProcessUtil.logInfo(log,
- AWOLoggerForProcessUtil.IDENTATION_LEVEL_GENERAL_PROCESS,
+ AWOLoggerForProcessUtil.logInfo(log, AWOLoggerForProcessUtil.IDENTATION_LEVEL_GENERAL_PROCESS,
           "Started calculation of occupancy for storage bin '%s'", locator.getIdentifier());
 
       if (!OccupancyUtils.isLocatorConfiguredForOccupancy(locatorId)) {
Additional Information
TagsPerformance
Relationships
related to design defect 0040759 new Triage Omni WMS Performance problems when auto-confirming hundreds of Box Tasks 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-05-09 12:58dmiguelezNew Issue
2019-05-09 12:58dmiguelezAssigned To => Triage Finance
2019-05-09 13:36SandrahuguetAssigned ToTriage Finance => nonofrancisco
2019-05-15 10:44dmitry_mezentsevRelationship addedrelated to 0040759
2019-05-16 23:51nonofranciscoStatusnew => scheduled
2019-05-21 15:46SandrahuguetTag Attached: Performance
2019-05-24 11:28hgbotCheckin
2019-05-24 11:28hgbotNote Added: 0112119
2019-05-24 11:28SandrahuguetStatusscheduled => resolved
2019-05-24 11:28SandrahuguetResolutionopen => fixed
2019-05-24 11:29SandrahuguetReview Assigned To => Sandrahuguet
2019-05-24 11:29SandrahuguetNote Added: 0112120
2019-05-24 11:29SandrahuguetStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0112119)
hgbot   
2019-05-24 11:28   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: ec316821859325b1c524f0a5d5d7ab30644c1585
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Tue May 21 17:06:51 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/ec316821859325b1c524f0a5d5d7ab30644c1585 [^]

Fix for issue 40820: Avoid logs to improve performance

Avoids log creation in flows where it is not necessary.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/occupancy/OccupancyCalculator.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/occupancy/OccupancyUtils.java
---
(0112120)
Sandrahuguet   
2019-05-24 11:29   
code review + testing ok