Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0040574 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 05. Production management | minor | have not tried | 2019-04-10 11:41 | 2019-06-05 20:54 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | nonofrancisco | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR19Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 014ef9ca9806 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR19Q3 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | Sandrahuguet | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0040574: SequenceProductCreate.getLineNum is not using bind-parameters | |||||||
| Description | This code is not using bind-params: String hql = " SELECT COALESCE(MAX(l.lineNo),0)+10 AS DefaultValue FROM ManufacturingOperationProduct l WHERE l.mASequence.id= '" + SequenceId + "'"; Query<Long> q = OBDal.getInstance().getSession().createQuery(hql, Long.class); | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||||||||||||||||
|
||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0111608) nonofrancisco (developer) 2019-05-09 23:45 |
Test Plan As Openbravo/F&B International Group Admin Open Activity window Create a new record Open Product window Create a new record Set production = true Open Process Plan window Create a new record Go to Version tab Create a new record Go to Operations tab Create a new record Set Activity to the previously created one Go to I/O Products tab Create a new record Set product to the previously created one Click on Create Product Copy button Accept default values Verify a new product is created with line number 20 |
|
(0112417) hgbot (developer) 2019-06-05 13:11 |
Repository: erp/devel/pi Changeset: 014ef9ca9806dd5d349dd2b31293a6ffc271e5d6 Author: Nono Carballo <nonofce <at> gmail.com> Date: Wed May 01 22:53:24 2019 -0400 URL: http://code.openbravo.com/erp/devel/pi/rev/014ef9ca9806dd5d349dd2b31293a6ffc271e5d6 [^] Fixes issue 40574: Uses bind parameter. Instead of string concatenation, bind parameter is used to build the query. --- M src/org/openbravo/erpCommon/ad_actionButton/SequenceProductCreate.java --- |
|
(0112429) Sandrahuguet (developer) 2019-06-05 15:54 |
code review + testing ok |
|
(0112444) hudsonbot (developer) 2019-06-05 20:54 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a8037910e3ad [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-04-10 11:41 | shuehner | New Issue | |
| 2019-04-10 11:41 | shuehner | Assigned To | => Triage Finance |
| 2019-04-10 11:41 | shuehner | Modules | => Core |
| 2019-04-10 11:41 | shuehner | Triggers an Emergency Pack | => No |
| 2019-04-10 11:41 | shuehner | Relationship added | blocks 0038136 |
| 2019-05-02 05:24 | nonofrancisco | Status | new => scheduled |
| 2019-05-03 11:58 | Sandrahuguet | Assigned To | Triage Finance => nonofrancisco |
| 2019-05-09 23:24 | nonofrancisco | Status | scheduled => acknowledged |
| 2019-05-09 23:25 | nonofrancisco | Status | acknowledged => scheduled |
| 2019-05-09 23:45 | nonofrancisco | Note Added: 0111608 | |
| 2019-05-13 12:37 | shuehner | Target Version | => 3.0PR19Q3 |
| 2019-06-05 13:11 | hgbot | Checkin | |
| 2019-06-05 13:11 | hgbot | Note Added: 0112417 | |
| 2019-06-05 13:11 | hgbot | Status | scheduled => resolved |
| 2019-06-05 13:11 | hgbot | Resolution | open => fixed |
| 2019-06-05 13:11 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/014ef9ca9806dd5d349dd2b31293a6ffc271e5d6 [^] |
| 2019-06-05 15:54 | Sandrahuguet | Review Assigned To | => Sandrahuguet |
| 2019-06-05 15:54 | Sandrahuguet | Note Added: 0112429 | |
| 2019-06-05 15:54 | Sandrahuguet | Status | resolved => closed |
| 2019-06-05 15:54 | Sandrahuguet | Fixed in Version | => 3.0PR19Q3 |
| 2019-06-05 20:54 | hudsonbot | Checkin | |
| 2019-06-05 20:54 | hudsonbot | Note Added: 0112444 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |