0040573: POSUtils.hasCurrencyRate is not using bind-parameters

Description

This code is not using bind-params:

      Query currencyRateQuery = OBDal.getInstance()
          .getSession()
          .createQuery("select obpos_currency_rate(coalesce(c, p.paymentMethod.currency), "
              + "p.obposApplications.organization.currency,"
              + " null, null, p.obposApplications.client.id, "
              + "p.obposApplications.organization.id) as rate, obpos_currency_rate(p.obposApplications.organization.currency, p.financialAccount.currency, null, null, p.obposApplications.client.id, p.obposApplications.organization.id) as mulrate"
              + " from OBPOS_App_Payment as p left join p.financialAccount as f "
              + "left join f.currency as c where p.obposApplications.id ='" + posTerminalId + "'");

Steps To Reproduce

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

design defect

0038136

acknowledged

Triage Platform Base

Openbravo ERP

Tracking issue: Find & Fix queries not using bind-params but embedding values into query string

Notes
(0111709) hgbot (developer) 2019-05-16 10:03	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: c811422b0a8894268d60fc1ea1776832898b3ff0 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Thu May 16 13:32:53 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c811422b0a8894268d60fc1ea1776832898b3ff0 [^] Fixed issue 40573 : POSUtils.hasCurrencyRate is not using bind-parameters --- M src/org/openbravo/retail/posterminal/POSUtils.java ---

Issue History
Date Modified	Username	Field	Change
2019-04-10 11:30	shuehner	New Issue
2019-04-10 11:30	shuehner	Assigned To	=> Retail
2019-04-10 11:30	shuehner	Triggers an Emergency Pack	=> No
2019-04-10 11:30	shuehner	Relationship added	blocks 0038136
2019-05-13 12:44	shuehner	Target Version	=> RR19Q3
2019-05-13 13:56	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2019-05-14 11:06	ranjith_qualiantech_com	Status	new => scheduled
2019-05-16 10:03	hgbot	Checkin
2019-05-16 10:03	hgbot	Note Added: 0111709
2019-05-16 10:03	hgbot	Status	scheduled => resolved
2019-05-16 10:03	hgbot	Resolution	open => fixed
2019-05-16 10:03	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c811422b0a8894268d60fc1ea1776832898b3ff0 [^]
2019-05-24 12:53	marvintm	Review Assigned To	=> marvintm
2019-05-24 12:53	marvintm	Status	resolved => closed
2019-05-24 12:53	marvintm	Fixed in Version	=> RR19Q3