Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040573Retail ModulesWeb POSpublic2019-04-10 11:302019-05-24 12:53
Reportershuehner 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR19Q3Fixed in VersionRR19Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040573: POSUtils.hasCurrencyRate is not using bind-parameters
DescriptionThis code is not using bind-params:

      Query currencyRateQuery = OBDal.getInstance()
          .getSession()
          .createQuery("select obpos_currency_rate(coalesce(c, p.paymentMethod.currency), "
              + "p.obposApplications.organization.currency,"
              + " null, null, p.obposApplications.client.id, "
              + "p.obposApplications.organization.id) as rate, obpos_currency_rate(p.obposApplications.organization.currency, p.financialAccount.currency, null, null, p.obposApplications.client.id, p.obposApplications.organization.id) as mulrate"
              + " from OBPOS_App_Payment as p left join p.financialAccount as f "
              + "left join f.currency as c where p.obposApplications.id ='" + posTerminalId + "'");
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-10 11:30shuehnerNew Issue
2019-04-10 11:30shuehnerAssigned To => Retail
2019-04-10 11:30shuehnerTriggers an Emergency Pack => No
2019-04-10 11:30shuehnerRelationship addedblocks 0038136
2019-05-13 12:44shuehnerTarget Version => RR19Q3
2019-05-13 13:56ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-05-14 11:06ranjith_qualiantech_comStatusnew => scheduled
2019-05-16 10:03hgbotCheckin
2019-05-16 10:03hgbotNote Added: 0111709
2019-05-16 10:03hgbotStatusscheduled => resolved
2019-05-16 10:03hgbotResolutionopen => fixed
2019-05-16 10:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c811422b0a8894268d60fc1ea1776832898b3ff0 [^]
2019-05-24 12:53marvintmReview Assigned To => marvintm
2019-05-24 12:53marvintmStatusresolved => closed
2019-05-24 12:53marvintmFixed in Version => RR19Q3

Notes
(0111709)
hgbot   
2019-05-16 10:03   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c811422b0a8894268d60fc1ea1776832898b3ff0
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu May 16 13:32:53 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c811422b0a8894268d60fc1ea1776832898b3ff0 [^]

Fixed issue 40573 : POSUtils.hasCurrencyRate is not using bind-parameters

---
M src/org/openbravo/retail/posterminal/POSUtils.java
---