Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0040569

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

minor

have not tried

2019-04-10 11:16

2019-05-24 13:25

Reporter

shuehner

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

normal

Resolution

fixed

Fixed in Version

RR19Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

RR19Q3

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

marvintm

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0040569: LabelsComponent.(getLabels+getLists) are not using bind-parameters

Description

Those 2 methods both are not using bind-params:

      String modules = getMobileAppDependantModuleIds(moduleId);
      JSONObject labels = new JSONObject();
      String hqlLabel = "select message.searchKey, message.messageText "//
          + "from ADMessage message " //
          + "where module.id in " + modules;

      String hqlTrlLabels = "select trl.message.searchKey, trl.messageText from ADMessageTrl trl where trl.message.module.id in "
          + modules + " and trl.language.id='" + langId + "'";

and

      String hqlLists = "select list.reference.id, list.searchKey as id, coalesce("
          + " (select trl.name from list.aDListTrlList trl where trl.language.id = '" + langId
          + "'), list.name) as name " + "from ADList list " //
          + "where list.reference.module.id in " + modules + " and list.module.id in " + modules
          + "order by list.reference.id, list.sequenceNumber";
      Query<Object[]> qryLists = OBDal.getInstance()
          .getSession()
          .createQuery(hqlLists, Object[].class);

Steps To Reproduce

-

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0040568	RR19Q3	closed	ranjith_qualiantech_com	Retail Modules	RolePermissions.getPrefList is not using bind-parameters
blocks	design defect	0038136		acknowledged	Triage Platform Base	Openbravo ERP	Tracking issue: Find & Fix queries not using bind-params but embedding values into query string

Notes
(0111704) hgbot (developer) 2019-05-16 10:01	Repository: erp/pmods/org.openbravo.mobile.core Changeset: 0d335e8c085ec60d0b829cda329142473362ea1f Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Thu May 16 13:31:39 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0d335e8c085ec60d0b829cda329142473362ea1f [^] Fixed issue 40569 : LabelsComponent.(getLabels+getLists) are not using bind-parameters --- M src/org/openbravo/mobile/core/login/LabelsComponent.java ---

Issue History
Date Modified	Username	Field	Change
2019-04-10 11:16	shuehner	New Issue
2019-04-10 11:16	shuehner	Assigned To	=> Retail
2019-04-10 11:16	shuehner	Triggers an Emergency Pack	=> No
2019-04-10 11:17	shuehner	Relationship added	blocks 0038136
2019-04-10 11:17	shuehner	Relationship added	related to 0040568
2019-04-10 12:40	shuehner	Description Updated	View Revisions
2019-05-13 12:44	shuehner	Target Version	=> RR19Q3
2019-05-13 13:56	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2019-05-14 11:06	ranjith_qualiantech_com	Status	new => scheduled
2019-05-16 10:01	hgbot	Checkin
2019-05-16 10:01	hgbot	Note Added: 0111704
2019-05-16 10:01	hgbot	Status	scheduled => resolved
2019-05-16 10:01	hgbot	Resolution	open => fixed
2019-05-16 10:01	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0d335e8c085ec60d0b829cda329142473362ea1f [^]
2019-05-24 13:25	marvintm	Review Assigned To	=> marvintm
2019-05-24 13:25	marvintm	Status	resolved => closed
2019-05-24 13:25	marvintm	Fixed in Version	=> RR19Q3

Copyright © 2000 - 2009 MantisBT Group