Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040569Retail ModulesWeb POSpublic2019-04-10 11:162019-05-24 13:25
Reportershuehner 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR19Q3Fixed in VersionRR19Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040569: LabelsComponent.(getLabels+getLists) are not using bind-parameters
DescriptionThose 2 methods both are not using bind-params:

      String modules = getMobileAppDependantModuleIds(moduleId);
      JSONObject labels = new JSONObject();
      String hqlLabel = "select message.searchKey, message.messageText "//
          + "from ADMessage message " //
          + "where module.id in " + modules;

      String hqlTrlLabels = "select trl.message.searchKey, trl.messageText from ADMessageTrl trl where trl.message.module.id in "
          + modules + " and trl.language.id='" + langId + "'";


and

      String hqlLists = "select list.reference.id, list.searchKey as id, coalesce("
          + " (select trl.name from list.aDListTrlList trl where trl.language.id = '" + langId
          + "'), list.name) as name " + "from ADList list " //
          + "where list.reference.module.id in " + modules + " and list.module.id in " + modules
          + "order by list.reference.id, list.sequenceNumber";
      Query<Object[]> qryLists = OBDal.getInstance()
          .getSession()
          .createQuery(hqlLists, Object[].class);
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040568RR19Q3 closed ranjith_qualiantech_com Retail Modules RolePermissions.getPrefList is not using bind-parameters 
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-10 11:16shuehnerNew Issue
2019-04-10 11:16shuehnerAssigned To => Retail
2019-04-10 11:16shuehnerOBNetwork customer => No
2019-04-10 11:16shuehnerTriggers an Emergency Pack => No
2019-04-10 11:17shuehnerRelationship addedblocks 0038136
2019-04-10 11:17shuehnerRelationship addedrelated to 0040568
2019-04-10 12:40shuehnerDescription Updatedbug_revision_view_page.php?rev_id=18615#r18615
2019-05-13 12:44shuehnerTarget Version => RR19Q3
2019-05-13 13:56ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-05-14 11:06ranjith_qualiantech_comStatusnew => scheduled
2019-05-16 10:01hgbotCheckin
2019-05-16 10:01hgbotNote Added: 0111704
2019-05-16 10:01hgbotStatusscheduled => resolved
2019-05-16 10:01hgbotResolutionopen => fixed
2019-05-16 10:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0d335e8c085ec60d0b829cda329142473362ea1f [^]
2019-05-24 13:25marvintmReview Assigned To => marvintm
2019-05-24 13:25marvintmStatusresolved => closed
2019-05-24 13:25marvintmFixed in Version => RR19Q3

Notes
(0111704)
hgbot   
2019-05-16 10:01   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0d335e8c085ec60d0b829cda329142473362ea1f
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu May 16 13:31:39 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0d335e8c085ec60d0b829cda329142473362ea1f [^]

Fixed issue 40569 : LabelsComponent.(getLabels+getLists) are not using bind-parameters

---
M src/org/openbravo/mobile/core/login/LabelsComponent.java
---