Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039495
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2018-10-22 12:362018-11-09 21:54
ReporteranderarangurenView Statuspublic 
Assigned Tojorge-garcia 
PrioritynormalResolutionfixedFixed in VersionRR19Q1
StatusclosedFix in branchFixed in SCM revisionfe8ab59ffca2
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039495: It is not possible to apply a manual promotion/discount to a negative line

DescriptionIt is not possible to apply a manual promotion/discount to a negative line
Steps To Reproduce1) Log in the WebPOS
2) Add a gps handheld and see that a discount is applied to the line
3) Go to menu and click on return this ticket.
4) The discount dissapears
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0035974 closedjorge-garcia It's possible to apply a manual promotion to a negative or a return line 
depends on backport 0039586RR18Q4 closedjorge-garcia It is not possible to apply a manual promotion/discount to a negative line 
depends on backport 0039587RR18Q3.3 closedjorge-garcia It is not possible to apply a manual promotion/discount to a negative line 
blocks defect 0051659 closedranjith_qualiantech_com Wrong discounts in deleted Lines 

-  Notes
(0107535)
hgbot (developer)
2018-10-24 08:39

 Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: fe8ab59ffca2688550e2a9dfbe294339a5acb446
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Oct 23 11:05:12 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/fe8ab59ffca2688550e2a9dfbe294339a5acb446 [^]

Fixed issue 39495: It is not possible to apply a manual promotion/discount
to a negative line

This commit includes:
  * Definition of a new column in m_offer table
  * A new field in discounts and promotions to allow to apply manual promotions
    to negative lines.
  * Change manual percentage calculation to work with negative lines.

---
M src-db/database/model/modifiedTables/M_OFFER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---
(0107536)
hgbot (developer)
2018-10-24 08:39

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3c6c9bffdc8a2b62e3afe054e4445732747048a7
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Oct 23 11:20:26 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3c6c9bffdc8a2b62e3afe054e4445732747048a7 [^]

Related to issue 39495: It is not possible to apply a manual promotion/discount
to a negative line

Change message to indicate current promotion could not be applied to negative
lines.

Use new flag definition to allow or to deny apply a manual promotion to a
negative line.

Save flag value in promotion applied.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0107537)
hgbot (developer)
2018-10-24 08:39

 Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: aac123c4a3c258de90c1e89a42694540170d728c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Oct 23 11:21:42 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/aac123c4a3c258de90c1e89a42694540170d728c [^]

Related to issue 39495: It is not possible to apply a manual promotion/discount
to a negative line

Add sampledata due to new column definition.

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
---
(0107538)
hgbot (developer)
2018-10-24 08:39

 Repository: erp/pmods/org.openbravo.retail.testsampledata
Changeset: 14c43475ad4b253fd63e7f2faf97333272b60c95
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Oct 24 08:38:46 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.testsampledata/rev/14c43475ad4b253fd63e7f2faf97333272b60c95 [^]

Related to issue 39495: It is not possible to apply a manual promotion/discount
to a negative line

Add sampledata due to new column definition.

---
M referencedata/sampledata/Retail_Test/M_OFFER.xml
---
(0107539)
jorge-garcia (reporter)
2018-10-24 08:41

 This commit is related with this issue:

https://code.openbravo.com/erp/pmods-branches/org.openbravo.test.mobile.sampledata/rev/f495618d0926 [^]
(0107760)
marvintm (manager)
2018-11-05 19:25

 When the discount is marked as "Allow to apply in negative lines", if I click on "Return line", the discount is deleted anyway.
(0107773)
hgbot (developer)
2018-11-07 08:44

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: aba1a3eb285a8183a800d95bbb246c26a11f0f9c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Nov 06 14:03:32 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aba1a3eb285a8183a800d95bbb246c26a11f0f9c [^]

Related to issue 39495: It is not possible to apply a manual promotion/discount
to a negative line

If the user change the quantity of the line using Return Line button or Return
this receipt, even if the manual promotion is marked to be applied in negative
lines, the discount disappears.

The problem now is fixed for both cases.

---
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0107827)
hgbot (developer)
2018-11-09 21:54

 Repository: tools/automation/pi-mobile
Changeset: 49383079f3eb1ed3aa9e4225b5714d25c70bbb17
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Thu Nov 08 16:02:18 2018 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/49383079f3eb1ed3aa9e4225b5714d25c70bbb17 [^]

Related to issue 39495: added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I39495_VerifyDiscountOnNegativeLine.java
---

- Issue History
Date Modified Username Field Change
2018-10-22 12:36 anderaranguren New Issue
2018-10-22 12:36 anderaranguren Assigned To => Retail
2018-10-22 12:36 anderaranguren Resolution time => 1541977200
2018-10-22 12:36 anderaranguren Triggers an Emergency Pack => No
2018-10-22 12:50 anderaranguren Relationship added related to 0035974
2018-10-23 09:18 jorge-garcia Status new => scheduled
2018-10-23 09:18 jorge-garcia Assigned To Retail => jorge-garcia
2018-10-24 08:39 hgbot Checkin
2018-10-24 08:39 hgbot Note Added: 0107535
2018-10-24 08:39 hgbot Status scheduled => resolved
2018-10-24 08:39 hgbot Resolution open => fixed
2018-10-24 08:39 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/fe8ab59ffca2688550e2a9dfbe294339a5acb446 [^]
2018-10-24 08:39 hgbot Checkin
2018-10-24 08:39 hgbot Note Added: 0107536
2018-10-24 08:39 hgbot Checkin
2018-10-24 08:39 hgbot Note Added: 0107537
2018-10-24 08:39 hgbot Checkin
2018-10-24 08:39 hgbot Note Added: 0107538
2018-10-24 08:41 jorge-garcia Note Added: 0107539
2018-10-29 13:38 marvintm Status resolved => new
2018-10-29 13:38 marvintm Resolution fixed => open
2018-10-29 13:39 marvintm Status new => scheduled
2018-10-29 13:39 marvintm Status scheduled => resolved
2018-10-29 13:39 marvintm Resolution open => fixed
2018-11-05 19:04 marvintm Status resolved => new
2018-11-05 19:04 marvintm Resolution fixed => open
2018-11-05 19:04 marvintm Status new => scheduled
2018-11-05 19:04 marvintm Status scheduled => resolved
2018-11-05 19:04 marvintm Fixed in Version => RR19Q1
2018-11-05 19:04 marvintm Resolution open => fixed
2018-11-05 19:25 marvintm Note Added: 0107760
2018-11-05 19:25 marvintm Status resolved => new
2018-11-05 19:25 marvintm Resolution fixed => open
2018-11-05 19:25 marvintm Fixed in Version RR19Q1 =>
2018-11-06 11:05 galderromo Issue Monitored: galderromo
2018-11-06 12:55 jorge-garcia Status new => scheduled
2018-11-07 08:44 hgbot Checkin
2018-11-07 08:44 hgbot Note Added: 0107773
2018-11-07 08:44 jorge-garcia Status scheduled => resolved
2018-11-07 08:44 jorge-garcia Resolution open => fixed
2018-11-07 13:47 marvintm Review Assigned To => marvintm
2018-11-07 13:47 marvintm Status resolved => closed
2018-11-07 13:47 marvintm Fixed in Version => RR19Q1
2018-11-09 21:54 hgbot Checkin
2018-11-09 21:54 hgbot Note Added: 0107827
2023-02-21 15:01 gorkaion Relationship added blocks 0051659

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker