Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039495Retail ModulesWeb POSpublic2018-10-22 12:362018-11-09 21:54
Reporteranderaranguren 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039495: It is not possible to apply a manual promotion/discount to a negative line
DescriptionIt is not possible to apply a manual promotion/discount to a negative line
Steps To Reproduce1) Log in the WebPOS
2) Add a gps handheld and see that a discount is applied to the line
3) Go to menu and click on return this ticket.
4) The discount dissapears
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035974 closed jorge-garcia It's possible to apply a manual promotion to a negative or a return line 
depends on backport 0039586RR18Q4 closed jorge-garcia It is not possible to apply a manual promotion/discount to a negative line 
depends on backport 0039587RR18Q3.3 closed jorge-garcia It is not possible to apply a manual promotion/discount to a negative line 
blocks defect 0051659 closed ranjith_qualiantech_com Wrong discounts in deleted Lines 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-10-22 12:36anderarangurenNew Issue
2018-10-22 12:36anderarangurenAssigned To => Retail
2018-10-22 12:36anderarangurenResolution time => 1541977200
2018-10-22 12:36anderarangurenTriggers an Emergency Pack => No
2018-10-22 12:50anderarangurenRelationship addedrelated to 0035974
2018-10-23 09:18jorge-garciaStatusnew => scheduled
2018-10-23 09:18jorge-garciaAssigned ToRetail => jorge-garcia
2018-10-24 08:39hgbotCheckin
2018-10-24 08:39hgbotNote Added: 0107535
2018-10-24 08:39hgbotStatusscheduled => resolved
2018-10-24 08:39hgbotResolutionopen => fixed
2018-10-24 08:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/fe8ab59ffca2688550e2a9dfbe294339a5acb446 [^]
2018-10-24 08:39hgbotCheckin
2018-10-24 08:39hgbotNote Added: 0107536
2018-10-24 08:39hgbotCheckin
2018-10-24 08:39hgbotNote Added: 0107537
2018-10-24 08:39hgbotCheckin
2018-10-24 08:39hgbotNote Added: 0107538
2018-10-24 08:41jorge-garciaNote Added: 0107539
2018-10-29 13:38marvintmStatusresolved => new
2018-10-29 13:38marvintmResolutionfixed => open
2018-10-29 13:39marvintmStatusnew => scheduled
2018-10-29 13:39marvintmStatusscheduled => resolved
2018-10-29 13:39marvintmResolutionopen => fixed
2018-11-05 19:04marvintmStatusresolved => new
2018-11-05 19:04marvintmResolutionfixed => open
2018-11-05 19:04marvintmStatusnew => scheduled
2018-11-05 19:04marvintmStatusscheduled => resolved
2018-11-05 19:04marvintmFixed in Version => RR19Q1
2018-11-05 19:04marvintmResolutionopen => fixed
2018-11-05 19:25marvintmNote Added: 0107760
2018-11-05 19:25marvintmStatusresolved => new
2018-11-05 19:25marvintmResolutionfixed => open
2018-11-05 19:25marvintmFixed in VersionRR19Q1 =>
2018-11-06 11:05galderromoIssue Monitored: galderromo
2018-11-06 12:55jorge-garciaStatusnew => scheduled
2018-11-07 08:44hgbotCheckin
2018-11-07 08:44hgbotNote Added: 0107773
2018-11-07 08:44jorge-garciaStatusscheduled => resolved
2018-11-07 08:44jorge-garciaResolutionopen => fixed
2018-11-07 13:47marvintmReview Assigned To => marvintm
2018-11-07 13:47marvintmStatusresolved => closed
2018-11-07 13:47marvintmFixed in Version => RR19Q1
2018-11-09 21:54hgbotCheckin
2018-11-09 21:54hgbotNote Added: 0107827
2023-02-21 15:01gorkaionRelationship addedblocks 0051659

Notes
(0107535)
hgbot   
2018-10-24 08:39   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: fe8ab59ffca2688550e2a9dfbe294339a5acb446
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Oct 23 11:05:12 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/fe8ab59ffca2688550e2a9dfbe294339a5acb446 [^]

Fixed issue 39495: It is not possible to apply a manual promotion/discount
to a negative line

This commit includes:
  * Definition of a new column in m_offer table
  * A new field in discounts and promotions to allow to apply manual promotions
    to negative lines.
  * Change manual percentage calculation to work with negative lines.

---
M src-db/database/model/modifiedTables/M_OFFER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---
(0107536)
hgbot   
2018-10-24 08:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3c6c9bffdc8a2b62e3afe054e4445732747048a7
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Oct 23 11:20:26 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3c6c9bffdc8a2b62e3afe054e4445732747048a7 [^]

Related to issue 39495: It is not possible to apply a manual promotion/discount
to a negative line

Change message to indicate current promotion could not be applied to negative
lines.

Use new flag definition to allow or to deny apply a manual promotion to a
negative line.

Save flag value in promotion applied.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0107537)
hgbot   
2018-10-24 08:39   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: aac123c4a3c258de90c1e89a42694540170d728c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Oct 23 11:21:42 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/aac123c4a3c258de90c1e89a42694540170d728c [^]

Related to issue 39495: It is not possible to apply a manual promotion/discount
to a negative line

Add sampledata due to new column definition.

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
---
(0107538)
hgbot   
2018-10-24 08:39   
Repository: erp/pmods/org.openbravo.retail.testsampledata
Changeset: 14c43475ad4b253fd63e7f2faf97333272b60c95
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Oct 24 08:38:46 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.testsampledata/rev/14c43475ad4b253fd63e7f2faf97333272b60c95 [^]

Related to issue 39495: It is not possible to apply a manual promotion/discount
to a negative line

Add sampledata due to new column definition.

---
M referencedata/sampledata/Retail_Test/M_OFFER.xml
---
(0107539)
jorge-garcia   
2018-10-24 08:41   
This commit is related with this issue:

https://code.openbravo.com/erp/pmods-branches/org.openbravo.test.mobile.sampledata/rev/f495618d0926 [^]
(0107760)
marvintm   
2018-11-05 19:25   
When the discount is marked as "Allow to apply in negative lines", if I click on "Return line", the discount is deleted anyway.
(0107773)
hgbot   
2018-11-07 08:44   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: aba1a3eb285a8183a800d95bbb246c26a11f0f9c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Nov 06 14:03:32 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aba1a3eb285a8183a800d95bbb246c26a11f0f9c [^]

Related to issue 39495: It is not possible to apply a manual promotion/discount
to a negative line

If the user change the quantity of the line using Return Line button or Return
this receipt, even if the manual promotion is marked to be applied in negative
lines, the discount disappears.

The problem now is fixed for both cases.

---
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0107827)
hgbot   
2018-11-09 21:54   
Repository: tools/automation/pi-mobile
Changeset: 49383079f3eb1ed3aa9e4225b5714d25c70bbb17
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Thu Nov 08 16:02:18 2018 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/49383079f3eb1ed3aa9e4225b5714d25c70bbb17 [^]

Related to issue 39495: added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I39495_VerifyDiscountOnNegativeLine.java
---