Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038935
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServercriticalhave not tried2018-07-11 17:572018-07-12 08:47
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionb9c82db30a89
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomtaal
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038935: Wrong check leads to infinite loop,which results in many requests being done from store to central server

DescriptionIn this issue [1] a check was added so that when a request from the store to the central server failed, the store server checked the central server availability before going offline.

The condition in the while loop is wrong, and if the central server is actually available, the while will become an infinite loop, and new availability requests will be made constantly from the store to the central server


[1] https://issues.openbravo.com/view.php?id=38505 [^]
Steps To ReproduceCheck this loop [1]. If the central is available, the isAvailable variable will be true, so the loop check will evaluate to true always.

[1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java#l241 [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0038505 closedAugustoMauch Before going offline do extra ping request 

-  Notes
(0105704)
hgbot (developer)
2018-07-11 18:04

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: b9c82db30a89d9f76e62ff6d59b115fd03fd3714
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Jul 11 18:03:34 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b9c82db30a89d9f76e62ff6d59b115fd03fd3714 [^]

Fixes issue 38935: Prevents infinite loop if isAvailable is set to true in loop

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java
---
(0105706)
mtaal (manager)
2018-07-12 08:47

 reviewed

- Issue History
Date Modified Username Field Change
2018-07-11 17:57 AugustoMauch New Issue
2018-07-11 17:57 AugustoMauch Assigned To => AugustoMauch
2018-07-11 17:57 AugustoMauch Triggers an Emergency Pack => No
2018-07-11 17:57 AugustoMauch Relationship added related to 0038505
2018-07-11 18:04 hgbot Checkin
2018-07-11 18:04 hgbot Note Added: 0105704
2018-07-11 18:04 hgbot Status new => resolved
2018-07-11 18:04 hgbot Resolution open => fixed
2018-07-11 18:04 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b9c82db30a89d9f76e62ff6d59b115fd03fd3714 [^]
2018-07-11 18:04 AugustoMauch Review Assigned To => mtaal
2018-07-12 08:47 mtaal Note Added: 0105706
2018-07-12 08:47 mtaal Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker