Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038935Retail ModulesStoreServerpublic2018-07-11 17:572018-07-12 08:47
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038935: Wrong check leads to infinite loop,which results in many requests being done from store to central server
DescriptionIn this issue [1] a check was added so that when a request from the store to the central server failed, the store server checked the central server availability before going offline.

The condition in the while loop is wrong, and if the central server is actually available, the while will become an infinite loop, and new availability requests will be made constantly from the store to the central server


[1] https://issues.openbravo.com/view.php?id=38505 [^]
Steps To ReproduceCheck this loop [1]. If the central is available, the isAvailable variable will be true, so the loop check will evaluate to true always.

[1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java#l241 [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0038505 closed AugustoMauch Before going offline do extra ping request 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-07-11 17:57AugustoMauchNew Issue
2018-07-11 17:57AugustoMauchAssigned To => AugustoMauch
2018-07-11 17:57AugustoMauchTriggers an Emergency Pack => No
2018-07-11 17:57AugustoMauchRelationship addedrelated to 0038505
2018-07-11 18:04hgbotCheckin
2018-07-11 18:04hgbotNote Added: 0105704
2018-07-11 18:04hgbotStatusnew => resolved
2018-07-11 18:04hgbotResolutionopen => fixed
2018-07-11 18:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b9c82db30a89d9f76e62ff6d59b115fd03fd3714 [^]
2018-07-11 18:04AugustoMauchReview Assigned To => mtaal
2018-07-12 08:47mtaalNote Added: 0105706
2018-07-12 08:47mtaalStatusresolved => closed

Notes
(0105704)
hgbot   
2018-07-11 18:04   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: b9c82db30a89d9f76e62ff6d59b115fd03fd3714
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Jul 11 18:03:34 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b9c82db30a89d9f76e62ff6d59b115fd03fd3714 [^]

Fixes issue 38935: Prevents infinite loop if isAvailable is set to true in loop

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java
---
(0105706)
mtaal   
2018-07-12 08:47   
reviewed