Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038449
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformtrivialhave not tried2018-04-25 14:112018-04-27 09:22
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q2
StatusclosedFix in branchFixed in SCM revisionb33d1c4cc375
ProjectionnoneETAnoneTarget Version3.0PR18Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038449: compilation warnings in src-core + buildvalidations: source/target value 6 is obsolete

DescriptionSome compilation tasks (openbravo-core and build validation) are still compiled with Java 6.

Since Java 9, this causes compilation warnings.

The purpose of this was:

- There is a build validation (JdkVersionCheck) that ensures JDK is at least 7, this to show a proper message, needs to with JDK6
- As the engine that executes build validations is in openbrav-core it also requires to be compiled with JDK6
Steps To ReproduceWith Java >=9 execute ant.core lib:


...
compile:
    [javac] Compiling 131 source files to /srv/ci/workspace/try-full-pgsql/src-core/build/classes
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 6
    [javac] warning: [options] source value 6 is obsolete and will be removed in a future release
    [javac] warning: [options] target value 1.6 is obsolete and will be removed in a future release
    [javac] warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
    [javac] 4 warnings
Proposed SolutionJDK check can be performed directly in ant, without need of executing any build validation. Moving it, would allow to compile core + build validations with current JDK version.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0038448 closedalostale compilation warnings in src-core + buildvalidations: source/target value 6 is obsolete 

-  Notes
(0104086)
hgbot (developer)
2018-04-26 09:39

 Repository: erp/backports/3.0PR18Q2
Changeset: b33d1c4cc375a52d73014982d611dc58a16447f0
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 26 07:46:08 2018 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR18Q2/rev/b33d1c4cc375a52d73014982d611dc58a16447f0 [^]

fixes 38449: compilation warnings in src-core + buildvalidations with JDK10

 JDK version validation is now performed directly in ant without need of executing
 and build validation (note checking only if it is 6 as before core was only compiled
 with 6, so it would have failed anyway if running with an older one).

 This allows to compile core and build validations with the same JDK as the rest.

---
M build.xml
M src-core/build.xml
M src-core/src/org/openbravo/buildvalidation/BuildValidationHandler.java
M src-util/buildvalidation/build.xml
R src-core/.settings/org.eclipse.jdt.core.prefs
R src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/JdkVersionCheck.class
R src-util/buildvalidation/src/org/openbravo/buildvalidation/JdkVersionCheck.java
---
(0104122)
caristu (developer)
2018-04-27 09:22

 Code reviewed + tested OK.

- Issue History
Date Modified Username Field Change
2018-04-25 14:15 alostale Type defect => backport
2018-04-25 14:15 alostale Target Version => 3.0PR18Q2
2018-04-26 09:39 hgbot Checkin
2018-04-26 09:39 hgbot Note Added: 0104086
2018-04-26 09:39 hgbot Status scheduled => resolved
2018-04-26 09:39 hgbot Resolution open => fixed
2018-04-26 09:39 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR18Q2/rev/b33d1c4cc375a52d73014982d611dc58a16447f0 [^]
2018-04-27 09:22 caristu Note Added: 0104122
2018-04-27 09:22 caristu Status resolved => closed
2018-04-27 09:22 caristu Fixed in Version => 3.0PR18Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker