Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0038297
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersminorhave not tried2018-04-08 17:272018-04-26 13:16
ReportershuehnerView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiond4b4b7b31846
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038297: API-Change: Removed org.openbravo.erpCommon.businessUtility.Heartbeat_data_xsql file & code revision columns

Descriptiona.) That file xsql was only used by openbravo internal code and having it public today was no longer necessary for any code in pi.

Checking all published modules using getAllModules script did not find any module using it.

What the file did was read data only related to heartbeat & Openbravo registration from ad_system_info table which are areas not known to be customized anyway.

b.) Removal of ad_system_info.code_revision field in database, ad_column, ad_field.
Also removed related entry CODE_REVISION in SystemInfo.Item.CODE_REVISION enum.

c.) Removal of ad_module.version_id and ad_module_install.version_id

Those did save 'mercurial revision' of main repo (ignoring modules) and were only used in 'an obsolete check for local changes in export.database which was changed to a checksum long time ago' and in sending that data to Openbravo heartbeat.

Checking for them in download of all published modules did also not show any module using them.

So risk of this API change should be very low.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0037500 closedshuehner Stop running 'hg id' during ant tasks (install.source & compilation) 

-  Notes
(0104092)
hgbot (developer)
2018-04-26 13:11

Repository: erp/devel/api-checks
Changeset: d4b4b7b31846438098700856353605d98b28d830
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 26 13:11:27 2018 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/d4b4b7b31846438098700856353605d98b28d830 [^]

fixes 38297: API-Change: Removed Heartbeat_data_xsql & code revision columns

---
M java/reference/java.japi.gz
M model/src-db/database/model/tables/AD_HEARTBEAT_LOG.xml
M model/src-db/database/model/tables/AD_MODULE.xml
M model/src-db/database/model/tables/AD_MODULE_INSTALL.xml
M model/src-db/database/model/tables/AD_SYSTEM_INFO.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_DATASET_COLUMN.xml
M model/src-db/database/sourcedata/AD_ELEMENT.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---

- Issue History
Date Modified Username Field Change
2018-04-08 17:27 shuehner New Issue
2018-04-08 17:27 shuehner Assigned To => Triage Finance
2018-04-08 17:27 shuehner Modules => Core
2018-04-08 17:27 shuehner Triggers an Emergency Pack => No
2018-04-08 17:27 shuehner Relationship added related to 0037500
2018-04-08 18:49 shuehner Assigned To Triage Finance => shuehner
2018-04-09 10:33 shuehner Summary API-Change: Removal of public org.openbravo.erpCommon.businessUtility.Heartbeat_data_xsql file => API-Change: Remove org.openbravo.erpCommon.businessUtility.Heartbeat_data_xsql file & ad_system_info.code_revision field
2018-04-09 10:33 shuehner Description Updated View Revisions
2018-04-26 13:10 alostale Summary API-Change: Remove org.openbravo.erpCommon.businessUtility.Heartbeat_data_xsql file & ad_system_info.code_revision field => API-Change: Removed org.openbravo.erpCommon.businessUtility.Heartbeat_data_xsql file & code revision columns
2018-04-26 13:10 alostale Description Updated View Revisions
2018-04-26 13:10 alostale Assigned To shuehner => alostale
2018-04-26 13:11 hgbot Checkin
2018-04-26 13:11 hgbot Note Added: 0104092
2018-04-26 13:11 hgbot Status new => resolved
2018-04-26 13:11 hgbot Resolution open => fixed
2018-04-26 13:11 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/d4b4b7b31846438098700856353605d98b28d830 [^]
2018-04-26 13:16 alostale Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker