0038297: API-Change: Removed org.openbravo.erpCommon.businessUtility.Heartbeat_data_xsql file & code revision columns

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0038297

Openbravo ERP

Z. Others

public

2018-04-08 17:27

2018-04-26 13:16

Reporter

shuehner

Assigned To

alostale

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0038297: API-Change: Removed org.openbravo.erpCommon.businessUtility.Heartbeat_data_xsql file & code revision columns

Description

a.) That file xsql was only used by openbravo internal code and having it public today was no longer necessary for any code in pi.

Checking all published modules using getAllModules script did not find any module using it.

What the file did was read data only related to heartbeat & Openbravo registration from ad_system_info table which are areas not known to be customized anyway.

b.) Removal of ad_system_info.code_revision field in database, ad_column, ad_field.
Also removed related entry CODE_REVISION in SystemInfo.Item.CODE_REVISION enum.

c.) Removal of ad_module.version_id and ad_module_install.version_id

Those did save 'mercurial revision' of main repo (ignoring modules) and were only used in 'an obsolete check for local changes in export.database which was changed to a checksum long time ago' and in sending that data to Openbravo heartbeat.

Checking for them in download of all published modules did also not show any module using them.

So risk of this API change should be very low.

Steps To Reproduce

Proposed Solution

Additional Information